Skip to content

Conversation

@p-hoffmann
Copy link
Member

No description provided.

@p-hoffmann p-hoffmann requested a review from Copilot January 2, 2026 13:35
@p-hoffmann p-hoffmann marked this pull request as ready for review January 2, 2026 13:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds optional TrexSQL caching functionality to WebAPI, providing an alternative vocabulary search provider that can serve searches from pre-built cache databases.

Key changes:

  • Introduces TrexSQL integration components with conditional activation via configuration
  • Adds new TREXSQL enum value to VocabularySearchProviderType
  • Configures Maven dependency for trexsql-ext library with tcache profile support

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 17 comments.

Show a summary per file
File Description
src/main/resources/application.properties Adds Jackson date serialization config and TrexSQL configuration properties (enabled, cache-path, extensions-path)
src/main/java/org/ohdsi/webapi/vocabulary/VocabularySearchProviderType.java Adds TREXSQL enum constant to support new search provider type
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLSourceConfig.java New configuration class for per-source TrexSQL settings (enabled flag, database code)
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLServletConfig.java Configures TrexServlet registration with conditional activation when trexsql.enabled=true
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLService.java Service layer providing TrexSQL operations including cache availability checking and vocabulary search
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLSearchProvider.java SearchProvider implementation that delegates vocabulary searches to TrexSQL cache
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLInstanceManager.java Singleton manager for TrexSQL instance with lazy initialization and thread-safe lifecycle management
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLConfig.java Main configuration class mapping trexsql.* properties with source-specific configurations
src/main/java/org/ohdsi/webapi/WebApi.java Removes a line from javadoc comment (unrelated change)
pom.xml Adds trexsql-ext dependency, JitPack repository, tcache profile, and logging configuration for tests
README.md Adds trailing newline (formatting fix)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@p-hoffmann p-hoffmann merged commit 28c58e4 into webapi-3.0 Jan 2, 2026
2 checks passed
@p-hoffmann p-hoffmann deleted the p-hoffmann/cache branch January 2, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants