-
Notifications
You must be signed in to change notification settings - Fork 178
add optional cache #2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add optional cache #2475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds optional TrexSQL caching functionality to WebAPI, providing an alternative vocabulary search provider that can serve searches from pre-built cache databases.
Key changes:
- Introduces TrexSQL integration components with conditional activation via configuration
- Adds new TREXSQL enum value to VocabularySearchProviderType
- Configures Maven dependency for trexsql-ext library with tcache profile support
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/resources/application.properties |
Adds Jackson date serialization config and TrexSQL configuration properties (enabled, cache-path, extensions-path) |
src/main/java/org/ohdsi/webapi/vocabulary/VocabularySearchProviderType.java |
Adds TREXSQL enum constant to support new search provider type |
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLSourceConfig.java |
New configuration class for per-source TrexSQL settings (enabled flag, database code) |
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLServletConfig.java |
Configures TrexServlet registration with conditional activation when trexsql.enabled=true |
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLService.java |
Service layer providing TrexSQL operations including cache availability checking and vocabulary search |
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLSearchProvider.java |
SearchProvider implementation that delegates vocabulary searches to TrexSQL cache |
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLInstanceManager.java |
Singleton manager for TrexSQL instance with lazy initialization and thread-safe lifecycle management |
src/main/java/org/ohdsi/webapi/trexsql/TrexSQLConfig.java |
Main configuration class mapping trexsql.* properties with source-specific configurations |
src/main/java/org/ohdsi/webapi/WebApi.java |
Removes a line from javadoc comment (unrelated change) |
pom.xml |
Adds trexsql-ext dependency, JitPack repository, tcache profile, and logging configuration for tests |
README.md |
Adds trailing newline (formatting fix) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.