Prevent page unload crash #3535
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Both QtCreator and VSCode are unusable pieces of crap and can't be used to make PRs. |
slapin
force-pushed
the
paging-prevent-load-unload-clash
branch
2 times, most recently
from
c054d80 to
34700a5
Compare
slapin
force-pushed
the
paging-prevent-load-unload-clash
branch
from
34700a5 to
2687823
Compare
paroj
reviewed
Dec 26, 2025
slapin
force-pushed
the
paging-prevent-load-unload-clash
branch
2 times, most recently
from
98bfd86 to
b379a51
Compare
Contributor
Author
|
using boolean does not solve the problem |
Contributor
Author
|
solution with future had much more impact, however |
paroj
reviewed
Dec 26, 2025
Components/Paging/src/OgrePage.cpp
Outdated
| PageResponse pres = any_cast<PageResponse>(res->getData()); | ||
|
|
||
| // final loading behaviour | ||
| if (res->succeeded()) |
Member
There was a problem hiding this comment.
Suggested change
| if (res->succeeded() && !mInUnload) |
the cleanup should still run
Contributor
Author
There was a problem hiding this comment.
looks like mInUpload is already non-zero when handleResponse hits and crashes.
but unload() effect is still there. So I guess if it did not crash on first handleResponse it will crash on second one. At least it looks like it. So just boolean is not enough. Or it should be cleared by some different condition...
Contributor
Author
There was a problem hiding this comment.
looks like if I clear it in load() the problem is no longer reproducible...
slapin
force-pushed
the
paging-prevent-load-unload-clash
branch
from
b379a51 to
2e33334
Compare
Contributor
Author
|
Tested a bit and was not able to reproduce the problem so getting it out of draft... |
slapin
force-pushed
the
paging-prevent-load-unload-clash
branch
from
2e33334 to
6ee43ff
Compare
If page load is in progress, page load can
crash as the load finalizer is executed after unload.
Using additional boolean to prevent this.
To test the reproduction I create ImGui Button which runs
WorldPartition's unloadPage with PageID calculated using
current camera position. Before this change it resulted in
the following backtrace in unlucky case:
Thread 1 "Editor" received signal SIGSEGV, Segmentation fault.
0x00007ffff7f00f91 in Ogre::Page::handleResponse (this=0x5555586a96d0, res=0x7fffe8006900, srcQ=0x0) at /media/slapin/library/ogre3/ogre/Components/Paging/src/OgrePage.cpp:233
233 loadImpl();
(gdb) bt
#0 0x00007ffff7f00f91 in Ogre::Page::handleResponse (this=0x5555586a96d0, res=0x7fffe8006900, srcQ=0x0) at /media/slapin/library/ogre3/ogre/Components/Paging/src/OgrePage.cpp:233
OGRECave#1 0x00007ffff7f00aa0 in operator() (__closure=0x7fffffffd830) at /media/slapin/library/ogre3/ogre/Components/Paging/src/OgrePage.cpp:186
OGRECave#2 0x00007ffff7f02476 in std::__invoke_impl<void, Ogre::Page::load(bool)::<lambda()>::<lambda()>&>(std::__invoke_other, struct {...} &) (__f=...) at /usr/include/c++/11/bits/invoke.h:61
OGRECave#3 0x00007ffff7f02208 in std::__invoke_r<void, Ogre::Page::load(bool)::<lambda()>::<lambda()>&>(struct {...} &) (__fn=...) at /usr/include/c++/11/bits/invoke.h:154
OGRECave#4 0x00007ffff7f01ff6 in std::_Function_handler<void(), Ogre::Page::load(bool)::<lambda()>::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/11/bits/std_function.h:290
OGRECave#5 0x00007ffff7173b42 in std::function<void ()>::operator()() const (this=0x7fffffffd830) at /usr/include/c++/11/bits/std_function.h:590
OGRECave#6 0x00007ffff7173565 in Ogre::DefaultWorkQueueBase::processMainThreadTasks (this=0x5555562b0ff0) at /media/slapin/library/ogre3/ogre/OgreMain/src/OgreWorkQueue.cpp:176
OGRECave#7 0x00007ffff701aaf3 in Ogre::Root::_fireFrameEnded (this=0x5555562acfe0, evt=...) at /media/slapin/library/ogre3/ogre/OgreMain/src/OgreRoot.cpp:685
OGRECave#8 0x00007ffff701ac11 in Ogre::Root::_fireFrameEnded (this=0x5555562acfe0) at /media/slapin/library/ogre3/ogre/OgreMain/src/OgreRoot.cpp:712
OGRECave#9 0x00007ffff701b162 in Ogre::Root::renderOneFrame (this=0x5555562acfe0) at /media/slapin/library/ogre3/ogre/OgreMain/src/OgreRoot.cpp:792
OGRECave#10 0x00007ffff701b089 in Ogre::Root::startRendering (this=0x5555562acfe0) at /media/slapin/library/ogre3/ogre/OgreMain/src/OgreRoot.cpp:779
OGRECave#11 0x00005555555c341e in main () at /media/slapin/library/ogre3/ogre-projects/world2/src/editor/main.cpp:835
Closes: #3550
slapin
force-pushed
the
paging-prevent-load-unload-clash
branch
from
6ee43ff to
52bc11f
Compare
Contributor
Author
|
Reproduced the problem again. With the same backtrace. |
Contributor
Author
|
It is very hard to reproduce now but still reproducible. |
Contributor
Author
|
For some reason it is no longer possible to reproduce this under valgrind or it is super rare to do... |
Contributor
Author
|
Still can't reproduce, removing from draft. If I can reproduce it again will debug again... |
Member
|
even if this is incomplete, the changes here are necessary.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If page load is in progress, page load can
crash as the load finaliser is executed after unload.
To test the reproduction I create ImGui Button which runs WorldPartition's unloadPage with PageID calculated using current camera position. Before this change it resulted in the following backtrace in unlucky case:
Closes: #3530