Give OgreOggListener its own Movable Object Type name#48
Open
chillywillysoft wants to merge 1 commit intoOGRECave:masterfrom
Open
Give OgreOggListener its own Movable Object Type name#48chillywillysoft wants to merge 1 commit intoOGRECave:masterfrom
chillywillysoft wants to merge 1 commit intoOGRECave:masterfrom
Conversation
…constant names. Note that destroyAllMovableObjectsByType() does not destroy the Listener since it wasn't created through the SceneManager. It is destroyed by _destroyListener()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OgreOggListener's override of MovableObject::getMovableType() returns the same name as OgreOggISound. One of the main reasons for getting the type is to be able to cast the pointer to a pointer to a specific derived class, which this shared name prevents. A current workaround is to compare the pointer to the singleton's listener:
This PR gives the Listener its own name. It also changes the constants' names to the new MOT_* style. It breaks existing code so I understand if you don't want to merge this one.