[WIP] Attempt to update the testsuite subrepo #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hra687261
force-pushed
the
update_testsuite
branch
2 times, most recently
from
36a7dc1 to
9eca53f
Compare
Member
|
@hra687261, please tell me when I should have a look at this one (I'm waiting as long as it is marked as draft, just telling so that we don't enter a deadlock where I wait for you to mark it as ready and where you wait my review before marking as ready :-)) |
Collaborator
Author
|
When it's no longer a marked as a draft, I'll let you know :) |
hra687261
force-pushed
the
update_testsuite
branch
2 times, most recently
from
ba6a245 to
709ed97
Compare
hra687261
force-pushed
the
update_testsuite
branch
from
cd567a3 to
9b4bd00
Compare
redianthus
reviewed
Jan 6, 2026
| let has_def_value = | ||
| match ty with Text.Ref_type (No_null, _) -> false | _ -> true | ||
| in | ||
| if (not init) && not has_def_value then Error (`Uninitialized_local id) |
Member
There was a problem hiding this comment.
Maybe do this in validate_binary instead so that it is checked for binary modules too
redianthus
reviewed
Jan 6, 2026
| begin match known_globals with | ||
| | Some n when idx >= n -> Error (`Unknown_global (Text.Raw idx)) | ||
| | _ -> Ok (Binary.Global_get idx) | ||
| end |
Member
There was a problem hiding this comment.
it should be checked by find_global or in typechecking phase already
redianthus
reviewed
Jan 6, 2026
| let* stack = Stack.pop_ref stack in | ||
| Stack.push [ i32 ] stack | ||
| | Ref_as_non_null -> | ||
| let* stack = Stack.pop_ref stack in |
Member
There was a problem hiding this comment.
let* rt, stack = Stack.pop_ref stack in
Stack.push rt stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to update the test suite and track/fix the various errors that happen after this update.
This was done while I was working on #851