Model with entry point #699
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S41d
force-pushed
the
model-with-entry-point
branch
from
28d6391 to
f45fee9
Compare
redianthus
reviewed
Jun 1, 2025
redianthus
reviewed
Jun 1, 2025
redianthus
reviewed
Jun 1, 2025
redianthus
reviewed
Jun 3, 2025
| (entry_point, Array.of_list model) | ||
| in | ||
| let entry_point = | ||
| if Option.is_none entry_point then model_entry_point else entry_point |
Member
There was a problem hiding this comment.
Does it make sense to keep the --entry-point argument for owi replay? Couldn't we remove it now? And if not, what happen when they are both defined?
Collaborator
Author
There was a problem hiding this comment.
I guess not, I'll remove the option
redianthus
reviewed
Jun 3, 2025
| val model_of_json : string -> (string option * Smtml.Model.t) Result.t | ||
|
|
||
| val model_of_scfg : string -> Smtml.Model.t Result.t | ||
| val model_of_scfg : string -> (string option * Smtml.Model.t) Result.t |
Member
There was a problem hiding this comment.
This could be a string * Smtml.Model.t now that the entry point is mandatory, right?
redianthus
reviewed
Jun 3, 2025
| in | ||
| { model with children = model.children @ ep } | ||
| | None -> model | ||
| in |
Member
There was a problem hiding this comment.
Do you think we could put the entry point first in the output model (followed by the symbols)? I find it easier to read this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.