test: improve coverage for operation and converter (Phase 5) #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive unit tests: operation_test.go (+184 lines): - TestGetByID_NotFound: error path for missing operations - TestSelectPending: filtering by pending conversion status - TestUpdateConversionStatus: status update verification - TestUpdateStorageFormat: format update verification - TestMigrationRerun: idempotent migration handling - TestGetTypesEmpty/SelectAllEmpty/SelectPendingEmpty: empty DB edge cases converter_test.go (+339 lines): - TestSideIndexToSide: side enum conversion with edge cases - TestStringToEntityType: entity type string parsing - TestToFloat64/TestToString: interface type conversion helpers - TestConverter_ParseMarkerPosition: marker coordinate extraction - TestConverter_CalculateEndFrame: frame count calculation - TestConverter_ParseEvent_Distance: event distance parsing - TestConverter_GetEntityStateAtFrame: entity state lookup Coverage improvements: - storage: 88.5% → 92.9% - server: 89.6% → 89.9% - Overall: 44.4% → 45.6%
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
internal/server/operation.goandinternal/storage/converter.goChanges
internal/server/operation_test.go(+184 lines)TestGetByID_NotFoundTestSelectPendingTestUpdateConversionStatusTestUpdateStorageFormatTestMigrationRerunTestGetTypesEmptyTestSelectAllEmptyTestSelectPendingEmptyinternal/storage/converter_test.go(+339 lines)TestSideIndexToSideTestStringToEntityTypeTestToFloat64TestToStringTestConverter_ParseMarkerPositionTestConverter_CalculateEndFrameTestConverter_ParseEvent_DistanceTestConverter_GetEntityStateAtFrameCoverage Improvements
Test plan