test: improve conversion and handler coverage (Phase 4) #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for error paths and edge cases in conversion and server packages: conversion/worker_test.go: - Add errorMockRepo for testing error paths - TestProcessOnce_SelectPendingError: Test SelectPending failure - TestProcessOnce_ConversionFailureStatusUpdateError: Test status update failure - TestConvertOperation_UpdateConvertingStatusError: Test converting status error - TestConvertOperation_UpdateStorageFormatError: Test format update error - TestConvertOperation_UpdateCompletedStatusError: Test completed status error - TestConvertOperation_UpdateDurationError: Test duration update (warning only) - TestConvertOperation_InvalidStorageFormat: Test unknown storage engine server/handler_test.go: - TestGetOperationFormat_EmptyStorageFormat: Test empty format defaults to json - TestGetOperationFormat_UnknownFormat: Test unknown format fallback - TestGetOperationManifest_FlatBuffers: Test flatbuffers content type - TestGetOperationManifest_JSONFormat: Test JSON format returns decoded manifest - TestGetOperationChunk_FlatBuffers: Test flatbuffers chunk content type - TestGetOperationChunk_EmptyStorageFormat: Test empty format default - TestGetMarker_WithExtension: Test deprecated .png extension stripping - TestGetAmmo_WithPaaExtension: Test .paa extension stripping - TestStoreOperation_MissingFile: Test missing file upload error - TestStoreOperation_InvalidMissionDuration: Test invalid duration - TestStoreOperation_WrongSecret: Test forbidden on wrong secret Coverage improvements: - conversion: 76.3% -> 91.5% - server: 88.5% -> 89.6% - Overall: 43.8% -> 44.4%
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
conversion/worker_test.go (+300 lines)
Added
errorMockRepoto test error paths in conversion worker:TestProcessOnce_SelectPendingErrorTestProcessOnce_ConversionFailureStatusUpdateErrorTestConvertOperation_UpdateConvertingStatusErrorTestConvertOperation_UpdateStorageFormatErrorTestConvertOperation_UpdateCompletedStatusErrorTestConvertOperation_UpdateDurationErrorTestConvertOperation_InvalidStorageFormatserver/handler_test.go (+450 lines)
Added edge case tests for handlers:
TestGetOperationFormat_EmptyStorageFormatTestGetOperationFormat_UnknownFormatTestGetOperationManifest_FlatBuffersTestGetOperationManifest_JSONFormatTestGetOperationChunk_FlatBuffersTestGetOperationChunk_EmptyStorageFormatTestGetMarker_WithExtensionTestGetAmmo_WithPaaExtensionTestStoreOperation_MissingFileTestStoreOperation_InvalidMissionDurationTestStoreOperation_WrongSecretTest plan
go test -cover ./...