test: improve storage package coverage (Phase 3) #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for previously uncovered functions in the storage package: - json_test.go: Add TestJSONEngineGetManifestReader - protobuf_test.go: Add TestProtobufEngineGetManifestReader and TestProtobufEngineGetManifestReaderMissingFile - flatbuffers_test.go: Add comprehensive tests for: - GetManifestReader (success and missing file cases) - Convert (end-to-end JSON to FlatBuffers conversion) - pbEntityTypeToString and pbSideToString helper functions - pbManifestToStorageManifest conversion function Storage package coverage increased from 62.0% to 88.5%. Overall coverage increased from 36.9% to 43.8%.
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
json_test.go
TestJSONEngineGetManifestReader: Verify GetManifestReader returns error (not supported)protobuf_test.go
TestProtobufEngineGetManifestReader: Verify GetManifestReader returns raw file contentTestProtobufEngineGetManifestReaderMissingFile: Verify error on missing fileflatbuffers_test.go
TestFlatBuffersEngineGetManifestReader: Verify GetManifestReader returns raw file contentTestFlatBuffersEngineGetManifestReaderMissingFile: Verify error on missing fileTestFlatBuffersEngineConvert: End-to-end test converting JSON to FlatBuffers formatTestFlatBuffersEngineConvertMissingFile: Verify error on missing input fileTestPbEntityTypeToString: Test protobuf entity type to string conversionTestPbSideToString: Test protobuf side to string conversionTestPbManifestToStorageManifest: Test full manifest conversion with entities and eventsTestPbManifestToStorageManifestEmpty: Test conversion of empty manifestTest plan
go test -cover ./internal/storage/...