[16.0][FIX] fetch..folder: make manual attach work again#3563
Open
[16.0][FIX] fetch..folder: make manual attach work again#3563
Conversation
NL66278
force-pushed
the
16.0-fix-fetchmail_attach_from_folder-manual-attach
branch
7 times, most recently
from
06ebbbc to
3fd2858
Compare
In the past manual attachment was limited to the model defined in the folder, by overriding the selection for the object in a fields_view_get method. This no longer works as the method is not called any more. Setting the selection to just this model through other methods also does not work, neither setting a default model on a Reference field. So basically now attaching a mail to any object is allowed.
NL66278
force-pushed
the
16.0-fix-fetchmail_attach_from_folder-manual-attach
branch
from
3fd2858 to
b69650a
Compare
NL66278
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As fetch_mail no longer returns a tuple, but just a raw message, manual attach resulted in an error.