Skip to content

[19.0] [MIG] base_cron_exclusion#3546

Open
PaulaMForgeFlow wants to merge 32 commits intoOCA:19.0from
ForgeFlow:19.0-mig-base_cron_exclusion
Open

[19.0] [MIG] base_cron_exclusion#3546
PaulaMForgeFlow wants to merge 32 commits intoOCA:19.0from
ForgeFlow:19.0-mig-base_cron_exclusion

Conversation

@PaulaMForgeFlow
Copy link

Standard migration

LoisRForgeFlow and others added 30 commits March 13, 2026 13:41
* [9.0][ADD] base_cron_exclusion

* [10.0][MIG] base_cron_exclusion

[11.0][MIG] base_cron_exclusion
Change license to LGPL to not limit the usage of this module
in private customizations.
Currently translated at 100.0% (3 of 3 strings)

Translation: server-tools-12.0/server-tools-12.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-base_cron_exclusion/zh_CN/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-13.0/server-tools-13.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-base_cron_exclusion/
Currently translated at 100.0% (3 of 3 strings)

Translation: server-tools-15.0/server-tools-15.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_cron_exclusion/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_cron_exclusion/
Currently translated at 100.0% (3 of 3 strings)

Translation: server-tools-16.0/server-tools-16.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_cron_exclusion/it/
Currently translated at 100.0% (3 of 3 strings)

Translation: server-tools-16.0/server-tools-16.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_cron_exclusion/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-18.0/server-tools-18.0-base_cron_exclusion
Translate-URL: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-base_cron_exclusion/
@PaulaMForgeFlow PaulaMForgeFlow force-pushed the 19.0-mig-base_cron_exclusion branch from 247fd1c to a7dcc23 Compare March 13, 2026 14:24
@PaulaMForgeFlow PaulaMForgeFlow marked this pull request as ready for review March 13, 2026 14:27
@PaulaMForgeFlow
Copy link
Author

@DavidJForgeFlow can you review this migration?

@classmethod
def _process_job(cls, db, cron_cr, job):
locked_crons = cls._lock_mutually_exclusive_cron(db, job["id"])
locked_crons = cls._lock_mutually_exclusive_cron(cron_cr.dbname, job["id"])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to not make sense, could you take a look?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

locked_crons = cls._lock_mutually_exclusive_cron(cron_cr.dbname, job["id"])
try:
res = super()._process_job(db, cron_cr, job)
res = super()._process_job(cron_cr, job)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one neither.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

from odoo.exceptions import ValidationError
from odoo.tests import TransactionCase

from odoo.addons.base.tests.common import TransactionCase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is also not needed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it.

@PaulaMForgeFlow PaulaMForgeFlow force-pushed the 19.0-mig-base_cron_exclusion branch from a7dcc23 to 62a6d32 Compare March 16, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.