[18.0][ADD] rma_sale_stock_restocking_fee_invoicing#505
Open
[18.0][ADD] rma_sale_stock_restocking_fee_invoicing#505
Conversation
sbejaoui
force-pushed
the
18.0-rma_sale_stock_restocking_fee_invoicing-sbj
branch
6 times, most recently
from
25e468d to
8ab1cf0
Compare
marielejeune
suggested changes
Nov 17, 2025
Contributor
marielejeune
left a comment
marielejeune
left a comment
There was a problem hiding this comment.
LGTM, 2 minor comments
Comment on lines
11
to
19
| restocking_fee_type = fields.Selection( | ||
| [ | ||
| ("no_fee", "No Restocking Fee"), | ||
| ("fixed", "Fixed Amount"), | ||
| ("percent", "Percentage"), | ||
| ], | ||
| default="no_fee", | ||
| help="Define whether the restocking fee is a fixed amount or a percentage.", | ||
| ) |
Contributor
There was a problem hiding this comment.
I would add a required=True attribute, since in the methods you check that restocking_fee_type != 'no_fee', you want to avoid false values.
Contributor
Author
There was a problem hiding this comment.
I removed the 'no_fee' option
sbejaoui
force-pushed
the
18.0-rma_sale_stock_restocking_fee_invoicing-sbj
branch
from
8ab1cf0 to
6e8ec12
Compare
This module extends the standard RMA flow and the behavior of `sale_stock_restocking_fee_invoicing` by allowing: - Fixed or percentage-based restocking fees. - Automatic fee application during RMA receipt. - Integration with different refund strategies: - Update sale order quantity. - Manual refund after receipt.
sbejaoui
force-pushed
the
18.0-rma_sale_stock_restocking_fee_invoicing-sbj
branch
from
6e8ec12 to
2e91e5d
Compare
sbejaoui
force-pushed
the
18.0-rma_sale_stock_restocking_fee_invoicing-sbj
branch
from
5558c74 to
cc6fc67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module extends the standard RMA flow and the behavior of
sale_stock_restocking_fee_invoicingby allowing:needs: OCA/stock-logistics-workflow#2150