Skip to content

[18.0][FIX] fastapi: create test data instead of relying on demo data#596

Closed
juancarlosonate-tecnativa wants to merge 1 commit intoOCA:18.0from
Tecnativa:18.0-fix-fastapi
Closed

[18.0][FIX] fastapi: create test data instead of relying on demo data#596
juancarlosonate-tecnativa wants to merge 1 commit intoOCA:18.0from
Tecnativa:18.0-fix-fastapi

Conversation

@juancarlosonate-tecnativa

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@lmignon
Copy link
Contributor

lmignon commented Feb 25, 2026

@juancarlosonate-tecnativa Why in 18.0?

@juancarlosonate-tecnativa
Copy link
Author

@juancarlosonate-tecnativa Why in 18.0?

In 18, in a fresh database, simply installing Fastapi and running the module tests causes the tests to fail.

@lmignon
Copy link
Contributor

lmignon commented Feb 25, 2026

@juancarlosonate-tecnativa Why in 18.0?

In 18, in a fresh database, simply installing Fastapi and running the module tests causes the tests to fail.

I agree on Odoo 19.0 but not on Odoo 18.0 otherwise the CI should fail from the creation of the branh 18.0 🤔

@juancarlosonate-tecnativa
Copy link
Author

@juancarlosonate-tecnativa Why in 18.0?

In 18, in a fresh database, simply installing Fastapi and running the module tests causes the tests to fail.

I agree on Odoo 19.0 but not on Odoo 18.0 otherwise the CI should fail from the creation of the branh 18.0 🤔

To be honest, I can’t determine the real issue. Aren’t you experiencing this error on your side as well?

Also, if you check the Runbot-baseonly for this PR, you can see that the demo data is NOT being loaded either.

I repeat, simply installing FastAPI in a clean database and running the tests causes them to fail.

@juancarlosonate-tecnativa
Copy link
Author

@lmignon I’ve found the real issue. endpoint_route_handler does not declare any module as a dependency, which propagates demo=False and affects the tests. I’m closing the PR to fix it at the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants