[15.0][ADD] report_qweb_decimal_place by AungKoKoLin1997 · Pull Request #697 · OCA/reporting-engine

AungKoKoLin1997 · 2022-12-13T08:43:13Z

This module intends to provide the base function for currencies to adjust the number of decimal places for the unit price in QWeb reports.
@qrtl

yostashiro · 2022-12-14T01:09:37Z

report_qweb_decimal_place/readme/USAGE.rst

+To apply price unit format:
+ - Go to Invoicing --> Configuration --> Currencies
+ - Check apply_price_unit_format field


Please move this to CONFIGURE.rst.

yostashiro · 2022-12-14T01:35:04Z

report_qweb_decimal_place/__manifest__.py

+    "version": "15.0.1.0.0",
+    "author": "Quartile Limited, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/reporting-engine",
+    "license": "AGPL-3",


Please make this LGPL.

yostashiro · 2022-12-14T01:53:26Z

report_qweb_decimal_place/reports/price_unit_value_format.xml

+            or
+            not currency.rounding >= 1"
+            >
+                <span t-esc="'{:,.2f}'.format(price_unit)" />


Can we go a bit further than fixing it at the second decimal? Let's add price_decimal_place field in res.currency and take the value from there.

yostashiro · 2022-12-14T02:28:16Z

report_qweb_decimal_place/reports/price_unit_value_format.xml

+            <t
+                t-if="round(price_unit) != price_unit
+            or
+            not currency.rounding >= 1"
+            >


Suggested change

<t

t-if="round(price_unit) != price_unit

or

not currency.rounding >= 1"

>

Let's get rid of this condition.

yostashiro · 2022-12-14T02:28:54Z

report_qweb_decimal_place/reports/price_unit_value_format.xml

+            <t
+                t-if="round(price_unit) == price_unit
+                and
+                currency.rounding >= 1"
+            >
+                <span t-esc="'{:,.0f}'.format(price_unit)" />
+            </t>


Suggested change

<t

t-if="round(price_unit) == price_unit

and

currency.rounding >= 1"

>

<span t-esc="'{:,.0f}'.format(price_unit)" />

</t>

Let's get rid of this for simplicity.

yostashiro · 2022-12-14T02:45:05Z

report_qweb_decimal_place/models/res_currency.py

+class ResCurrency(models.Model):
+    _inherit = "res.currency"
+
+    apply_price_unit_format = fields.Boolean()


Suggested change

apply_price_unit_format = fields.Boolean()

apply_price_decimal_place = fields.Boolean(help="Apply this decimal place to the unit price field of relevant PDF reports where appropriate customization is done.")

yostashiro · 2022-12-14T02:59:22Z

report_qweb_decimal_place/readme/DESCRIPTION.rst

+This module does the following:
+
+- Adds apply_price_unit_format in currency and the price_unit format of reports will depend on that field.


Suggested change

This module does the following:

- Adds apply_price_unit_format in currency and the price_unit format of reports will depend on that field.

This module intends to provide the base function for currencies to adjust the number of decimal places for the unit price in QWeb reports.

Installing this module alone does not affect the presentation of existing QWeb reports. Individual adjustments need to be done in separate modules in a manner similar to the following:

.. code-block:: xml

<?xml version="1.0" encoding="utf-8" ?>

<odoo>

<template

id="report_saleorder_document_inherit"

inherit_id="sale.report_saleorder_document"

>

<xpath expr="//tbody[@class='sale_tbody']//tr//td[3]" position="replace">

<td name="td_priceunit" class="text-right">

<t t-set="currency" t-value="doc.currency_id" />

<t t-set="price_unit" t-value="line.price_unit" />

<t t-call="report_qweb_decimal_place.price_unit_value_format" />

</td>

</xpath>

</template>

</odoo>

Background:

--------------

Odoo default reports display price unit with the decimal accuracy of product price configuration. However, globally applying the decimal accuracy setting is sometimes not appropriate under multi-currency settings where how unit prices should be presented differs depending on the currency.

For example, unit prices in JPY usually do not have decimals (with some exceptions depending on the industry), while those in USD may require up to 2-4 decimals. If we configure the decimal accuracy based on USD, the unit price presentation on PDF reports for JPY transactions may appear a bit unconventional.

yostashiro · 2022-12-14T07:47:19Z

report_qweb_decimal_place/readme/DESCRIPTION.rst

+    </odoo>
+
+Background:
+--------------


Suggested change

--------------

-----------

yostashiro · 2022-12-14T08:05:42Z

report_qweb_decimal_place/reports/price_unit_value_format.xml

+        -->
+        <t t-if="currency.apply_price_decimal_place">
+            <span
+                class="text-nowrap"


Do we need this class assignment?

Even we add this class or not, there is no huge impact. This just change a little spacing and I added this class because price_unit of sale_order_document don't use this class but others use this class like invoice(https://github.com/odoo/odoo/blob/23ef75f9250e6920e592b14a0cec2d1d9545824e/addons/account/views/report_invoice.xml#L85)

yostashiro · 2022-12-14T08:12:30Z

report_qweb_decimal_place/readme/DESCRIPTION.rst

+    <?xml version="1.0" encoding="utf-8" ?>
+    <odoo>
+        <template
+            id="report_saleorder_document_inherit"
+            inherit_id="sale.report_saleorder_document"
+        >
+            <xpath expr="//tbody[@class='sale_tbody']//tr//td[3]" position="replace">
+                <td name="td_priceunit" class="text-right">
+                    <t t-set="currency" t-value="doc.currency_id" />
+                    <t t-set="price_unit" t-value="line.price_unit" />
+                    <t t-call="report_qweb_decimal_place.price_unit_value_format" />
+                </td>
+            </xpath>
+        </template>
+    </odoo>


Suggested change

<?xml version="1.0" encoding="utf-8" ?>

<odoo>

<template

id="report_saleorder_document_inherit"

inherit_id="sale.report_saleorder_document"

>

<xpath expr="//tbody[@class='sale_tbody']//tr//td[3]" position="replace">

<td name="td_priceunit" class="text-right">

<t t-set="currency" t-value="doc.currency_id" />

<t t-set="price_unit" t-value="line.price_unit" />

<t t-call="report_qweb_decimal_place.price_unit_value_format" />

</td>

</xpath>

</template>

</odoo>

<template

id="report_saleorder_document_inherit"

inherit_id="sale.report_saleorder_document"

>

<xpath expr="//td[@name='td_priceunit']/span" position="replace">

<t t-set="currency" t-value="doc.currency_id" />

<t t-set="price_unit" t-value="line.price_unit" />

<t t-call="report_qweb_decimal_place.price_unit_value_format" />

</xpath>

</template>

Please double-check if this suggestion is valid.

Yes. This suggestion is valid.

yostashiro · 2022-12-14T08:13:32Z

report_qweb_decimal_place/reports/price_unit_value_format.xml

+        <!--
+            It should define the price_unit and currency value.
+            e.g.
+            <t t-set="price_unit" t-value="line.price_unit" />
+            <t t-set="currency" t-value="o.currency_id" />
+        -->


Suggested change



We can remove this as it's explained in readme.

yostashiro · 2023-01-03T14:20:09Z

report_qweb_decimal_place/readme/DESCRIPTION.rst

+    </template>
+
+Background:
+-----------


Suggested change

-----------

~~~~~~~~~~~

Pay attention to the blank line as well.

ref. OCA/maintainer-tools#455 (comment)

yostashiro · 2023-01-04T03:03:43Z

report_qweb_decimal_place/readme/CONFIGURE.rst

+To apply price unit format:
+ - Go to Invoicing --> Configuration --> Currencies
+ - Check apply_price_decimal_place field
+ - Define decimal place in price_decimal_place field


Suggested change

To apply price unit format:

- Go to Invoicing --> Configuration --> Currencies

- Check apply_price_decimal_place field

- Define decimal place in price_decimal_place field

To apply price unit format:

#. Go to Invoicing --> Configuration --> Currencies

#. Check apply_price_decimal_place field

#. Define decimal place in price_decimal_place field

yostashiro

Code review. 👍

github-actions · 2023-05-07T12:23:50Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

yostashiro suggested changes Dec 14, 2022

View reviewed changes

AungKoKoLin1997 force-pushed the 15.0-add_report_qweb_decimal_place branch from 8e05667 to 5113448 Compare December 14, 2022 07:48

AungKoKoLin1997 changed the title ~~[ADD] report_qweb_decimal_place~~ [15.0][ADD] report_qweb_decimal_place Dec 14, 2022

AungKoKoLin1997 requested a review from yostashiro December 14, 2022 07:52

yostashiro suggested changes Dec 14, 2022

View reviewed changes

yostashiro reviewed Jan 3, 2023

View reviewed changes

yostashiro reviewed Jan 4, 2023

View reviewed changes

yostashiro approved these changes Jan 4, 2023

View reviewed changes

AungKoKoLin1997 mentioned this pull request Jan 5, 2023

[3006][ADD] sale_report_qweb_decimal_place qrtl/fal-custom#6

Merged

[ADD] report_qweb_decimal_place

ffa22fd

AungKoKoLin1997 force-pushed the 15.0-add_report_qweb_decimal_place branch from be9ae4f to ffa22fd Compare January 5, 2023 03:04

AungKoKoLin1997 mentioned this pull request Jan 5, 2023

[16.0][ADD] report_qweb_decimal_place #709

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 7, 2023

github-actions bot closed this Jun 11, 2023

AungKoKoLin1997 mentioned this pull request Jun 15, 2023

[15.0][ADD] report_qweb_decimal_place #769

Merged

	apply_price_unit_format = fields.Boolean()
	apply_price_decimal_place = fields.Boolean(help="Apply this decimal place to the unit price field of relevant PDF reports where appropriate customization is done.")

		This module does the following:

		- Adds apply_price_unit_format in currency and the price_unit format of reports will depend on that field.

Uh oh!

Comments

Conversation

AungKoKoLin1997 commented Dec 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yostashiro left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AungKoKoLin1997 commented Dec 13, 2022 •

edited

Loading