[19.0][MIG] project_parent_task_filter: Migration to 19.0#1685
[19.0][MIG] project_parent_task_filter: Migration to 19.0#1685gdgellatly wants to merge 41 commits intoOCA:19.0from
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: project-12.0/project-12.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_parent_task_filter/es/
Currently translated at 100.0% (2 of 2 strings) Translation: project-12.0/project-12.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_parent_task_filter/de/
Currently translated at 100.0% (2 of 2 strings) Translation: project-13.0/project-13.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_parent_task_filter/ca/
Currently translated at 100.0% (1 of 1 strings) Translation: project-14.0/project-14.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/nl_NL/
Currently translated at 100.0% (1 of 1 strings) Translation: project-14.0/project-14.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/es_AR/
Currently translated at 100.0% (1 of 1 strings) Translation: project-14.0/project-14.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/fr_FR/
Currently translated at 100.0% (1 of 1 strings) Translation: project-14.0/project-14.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/fr/
Currently translated at 100.0% (2 of 2 strings) Translation: project-16.0/project-16.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent_task_filter/it/
Currently translated at 100.0% (2 of 2 strings) Translation: project-16.0/project-16.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent_task_filter/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: project-16.0/project-16.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent_task_filter/es/
Currently translated at 100.0% (2 of 2 strings) Translation: project-16.0/project-16.0-project_parent_task_filter Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent_task_filter/es_AR/
cadb5ff to
8fcabe0
Compare
8fcabe0 to
c0d3a18
Compare
alexey-pelykh
left a comment
There was a problem hiding this comment.
Clean migration. Simple view module — filter and group-by for parent tasks. LGTM.
alexey-pelykh
left a comment
There was a problem hiding this comment.
Review: project_parent_task_filter migration to 19.0
Clean migration of a view-only module. The view XML is identical to 18.0, and the manifest version is correctly bumped to 19.0.1.0.0. No Python code changes needed, which is consistent with the module's nature (search filters only).
Findings
Minor (non-blocking):
.potfile references Odoo Server 18.0 -- The template file ati18n/project_parent_task_filter.potline 7 still saysProject-Id-Version: Odoo Server 18.0. This should beOdoo Server 19.0for the 19.0 branch. Typicallyoca-gen-addon-readme/ the OCA bot handles this, so it may get auto-corrected, but worth noting.
Observations (informational):
- The XPath
//filter[@name='unassigned']targetingproject.view_task_search_formworks as confirmed by the author's test results. Good. - No tests in the module, which is acceptable for a view-only module -- OCA CI covers installability.
- The 41-commit history carries the full migration chain from 12.0, which is standard OCA practice.
- Translation files carry older
Project-Id-Versionreferences (12.0, 13.0, 14.0, 16.0) in their respective.poheaders. This is normal -- Weblate will update these on the next translation sync.
Verdict
Looks good. Straightforward migration with no code changes required. The .pot version header is a minor cosmetic issue that will likely be auto-corrected by OCA tooling.
Review posted via CorporateHub OCA review campaign
luisDIXMIT
left a comment
There was a problem hiding this comment.
Code review and tested on runboat, LGTM!
|
This PR has the |
Summary
Migration of
project_parent_task_filtermodule to 19.0.Test plan
--test-enable