Skip to content

[19.0][MIG] project_parent_task_filter: Migration to 19.0#1685

Open
gdgellatly wants to merge 41 commits intoOCA:19.0from
gdgellatly:19.0-mig-project_parent_task_filter
Open

[19.0][MIG] project_parent_task_filter: Migration to 19.0#1685
gdgellatly wants to merge 41 commits intoOCA:19.0from
gdgellatly:19.0-mig-project_parent_task_filter

Conversation

@gdgellatly
Copy link

@gdgellatly gdgellatly commented Feb 28, 2026

Summary

Migration of project_parent_task_filter module to 19.0.

  • Version bump to 19.0.1.0.0
  • No code changes required; view-only module fully compatible with v19

Test plan

  • Module installs successfully
  • No errors with --test-enable

emagdalenaC2i and others added 30 commits February 28, 2026 20:56
Currently translated at 100.0% (2 of 2 strings)

Translation: project-12.0/project-12.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_parent_task_filter/es/
Currently translated at 100.0% (2 of 2 strings)

Translation: project-12.0/project-12.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_parent_task_filter/de/
Currently translated at 100.0% (2 of 2 strings)

Translation: project-13.0/project-13.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-13-0/project-13-0-project_parent_task_filter/ca/
Currently translated at 100.0% (1 of 1 strings)

Translation: project-14.0/project-14.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/nl_NL/
Currently translated at 100.0% (1 of 1 strings)

Translation: project-14.0/project-14.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/es_AR/
Currently translated at 100.0% (1 of 1 strings)

Translation: project-14.0/project-14.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/fr_FR/
Currently translated at 100.0% (1 of 1 strings)

Translation: project-14.0/project-14.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-14-0/project-14-0-project_parent_task_filter/fr/
Currently translated at 100.0% (2 of 2 strings)

Translation: project-16.0/project-16.0-project_parent_task_filter
Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_parent_task_filter/it/
@gdgellatly gdgellatly force-pushed the 19.0-mig-project_parent_task_filter branch from cadb5ff to 8fcabe0 Compare February 28, 2026 21:11
@gdgellatly gdgellatly force-pushed the 19.0-mig-project_parent_task_filter branch from 8fcabe0 to c0d3a18 Compare February 28, 2026 21:40
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean migration. Simple view module — filter and group-by for parent tasks. LGTM.

@gdgellatly gdgellatly marked this pull request as ready for review March 1, 2026 03:45
Copy link
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: project_parent_task_filter migration to 19.0

Clean migration of a view-only module. The view XML is identical to 18.0, and the manifest version is correctly bumped to 19.0.1.0.0. No Python code changes needed, which is consistent with the module's nature (search filters only).

Findings

Minor (non-blocking):

  1. .pot file references Odoo Server 18.0 -- The template file at i18n/project_parent_task_filter.pot line 7 still says Project-Id-Version: Odoo Server 18.0. This should be Odoo Server 19.0 for the 19.0 branch. Typically oca-gen-addon-readme / the OCA bot handles this, so it may get auto-corrected, but worth noting.

Observations (informational):

  • The XPath //filter[@name='unassigned'] targeting project.view_task_search_form works as confirmed by the author's test results. Good.
  • No tests in the module, which is acceptable for a view-only module -- OCA CI covers installability.
  • The 41-commit history carries the full migration chain from 12.0, which is standard OCA practice.
  • Translation files carry older Project-Id-Version references (12.0, 13.0, 14.0, 16.0) in their respective .po headers. This is normal -- Weblate will update these on the next translation sync.

Verdict

Looks good. Straightforward migration with no code changes required. The .pot version header is a minor cosmetic issue that will likely be auto-corrected by OCA tooling.

Review posted via CorporateHub OCA review campaign

Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested on runboat, LGTM!

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.