[18.0][MIG] project_kanban_form_direct_access#1682
[18.0][MIG] project_kanban_form_direct_access#1682
Conversation
Currently, to access the project form view, users must click on "three dots>Settings". With this improvement, users only need to click on the project name.
| <xpath expr="//span[hasclass('o_text_overflow')]" position="attributes"> | ||
| <attribute name="groups">!project.group_project_manager</attribute> | ||
| <xpath expr="//span[hasclass('text-truncate')]" position="attributes"> | ||
| <attribute name="invisible">1</attribute> |
There was a problem hiding this comment.
Why are you making it invisible to everyone when before it was only invisible to the group_project_manager?
There was a problem hiding this comment.
The purpose of this module is to access the project from the Kanban view. To keep things simple, I used the old invisible field and added a new field to link directly to the project. What do you think?
There was a problem hiding this comment.
Yes, it looks right. Thanks for explaining it to me.
There was a problem hiding this comment.
@IriaAlonso Could you clarify the purpose of adding groups? If I change it to invisible, would that work for you?
There was a problem hiding this comment.
This restriction is to maintain the same restriction on who can access the form view. But I think all users can access it, I have to change that. So it would be good to keep it invisible.
There was a problem hiding this comment.
This restriction is to maintain the same restriction on who can access the form view. But I think all users can access it, I have to change that. So it would be good to keep it invisible.
It is already fixed in the original PR
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Clean migration. View-only module, nothing to trip over.
LGTM.
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Clean migration to 18.0. The view approach is correct: type="open" replaces the v17 type="edit", xpath targets updated from o_text_overflow to text-truncate matching the Odoo 18.0 base kanban view, and Bootstrap utility classes (fs-4 fw-bold text-primary) are consistent with the base view's styling.
The group restriction removal was discussed and confirmed by the original author -- all users can access the project form view, so invisible="1" is the right approach.
One minor nit:
- The view record id
project_buttom_kanban_viewcontains a typo ("buttom" instead of "button"). This is cosmetic and won't affect functionality, but it will persist as anir.model.dataexternal identifier in the database. Worth fixing before merge if convenient, but non-blocking.
Review posted via CorporateHub OCA review campaign
| @@ -0,0 +1,21 @@ | |||
| <odoo> | |||
| <record id="project_buttom_kanban_view" model="ir.ui.view"> | |||
There was a problem hiding this comment.
Nit: typo in the record id -- project_buttom_kanban_view should be project_button_kanban_view ("buttom" -> "button"). This becomes a persistent ir.model.data external identifier, so worth fixing while it's fresh.
|
This PR has the |
2 similar comments
|
This PR has the |
|
This PR has the |
5 participants
This PR fixed logic to support project v18
Migration from v17
Note:
project_sequencebeforeproject_kanban_form_direct_access. Name will double. Fixed it in [18.0][FIX] project_sequence: remove the inherited kanban view #1683