Skip to content

[18.0][MIG][WIP] pos_user_restriction: Migration to version 18.0 #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
christian-ramos-tecnativa wants to merge 31 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG][WIP] pos_user_restriction: Migration to version 18.0 #1455

christian-ramos-tecnativa wants to merge 31 commits into from

Conversation

@christian-ramos-tecnativa
Copy link

@christian-ramos-tecnativa christian-ramos-tecnativa commented Nov 11, 2025

Standard migration

@Tecnativa TT59219

eLBati and others added 30 commits November 11, 2025 16:58
@eLBati @christian-ramos-tecnativa
ADD pos_user_restriction
a984880 
Restrict some users to only access their assigned points of sale
@danimv5 @christian-ramos-tecnativa
Added translation using Weblate (Spanish)
a4ae980
@danimv5 @christian-ramos-tecnativa
Translated using Weblate (Spanish)
35b3586 
Currently translated at 100.0% (7 of 7 strings)

Translation: pos-12.0/pos-12.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_user_restriction/es/
@eLBati @christian-ramos-tecnativa
FIX pos_user_restriction allowing "User: Assigned POS Only" to see po…
e1bbba1 
…int of sale menu
@OCA-git-bot @christian-ramos-tecnativa
pos_user_restriction 12.0.1.0.1
d93fcaa
@legalsylvain @christian-ramos-tecnativa
[FIX] pos_user_restriction: disable test that are failing if pos_rest…
04bd344 
…aurant module is installed
@OCA-git-bot @christian-ramos-tecnativa
pos_user_restriction 12.0.1.0.2
8b8bbcc
@hkapatel-initos @christian-ramos-tecnativa
[IMP]pos_user_restriction: black, isort, prettier
9069185
@hkapatel-initos @christian-ramos-tecnativa
[MIG] pos_user_restriction: Migration to 14.0
80cd5ee
@AshishHirapara @christian-ramos-tecnativa
[IMP][14.0] pos_user_restriction
7c0a988 
Updated roadmap description
@christian-ramos-tecnativa
[MIG] pos_user_restriction: Migration to 15.0
b7f423c
@christian-ramos-tecnativa
[UPD] Update pos_user_restriction.pot
90d773e
@OCA-git-bot @christian-ramos-tecnativa
[UPD] README.rst
50ecb6b
@OCA-git-bot @christian-ramos-tecnativa
[UPD] README.rst
9bc186a
@weblate @christian-ramos-tecnativa
Update translation files
180da06 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-15.0/pos-15.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_user_restriction/
@mymage @christian-ramos-tecnativa
Translated using Weblate (Italian)
21ce8d8 
Currently translated at 100.0% (11 of 11 strings)

Translation: pos-15.0/pos-15.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_user_restriction/it/
@Ivorra78 @christian-ramos-tecnativa
Translated using Weblate (Spanish)
82be46f 
Currently translated at 100.0% (11 of 11 strings)

Translation: pos-15.0/pos-15.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-15-0/pos-15-0-pos_user_restriction/es/
@em230418 @christian-ramos-tecnativa
[IMP] pos_user_restriction: pre-commit auto fixes
9803353
@em230418 @christian-ramos-tecnativa
[MIG] pos_user_restriction: migrate to 17.0
a4117fd 
Migration notes:

1. Removed bypassing group check, since set_cashbox_pos in 16.0+
does not call has_groups method [1]

2. Removed hack in res_users.py, which should not be the case,
since in res.users' write method has_group is replaced with
_is_internal [2]

3. Removed several ir.model.access records for removed models:

- account.bank.statement.cashbox [3]
- account.cashbox.line [3]
- cash.box.out [4]

[1] odoo/odoo#113151
[2] odoo/odoo@dae28c4#diff-16e37db365c1ea1f2e6c79aeb60c80f68f1a5c75970e8e3f198eb18af56278dd
[3] odoo/odoo@4fb0933
[4] odoo/odoo@7e23eda

In this commit we remove bypassing group check
@em230418 @christian-ramos-tecnativa
[IMP] pos_user_restriction: add tests for get_closing_control_data
277cb22
@christian-ramos-tecnativa
[UPD] Update pos_user_restriction.pot
da28cc3
@OCA-git-bot @christian-ramos-tecnativa
[BOT] post-merge updates
332ab10
@weblate @christian-ramos-tecnativa
Update translation files
e71dd7f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-17.0/pos-17.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_user_restriction/
@mymage @christian-ramos-tecnativa
Translated using Weblate (Italian)
94cddd6 
Currently translated at 100.0% (12 of 12 strings)

Translation: pos-17.0/pos-17.0-pos_user_restriction
Translate-URL: https://translation.odoo-community.org/projects/pos-17-0/pos-17-0-pos_user_restriction/it/
@peluko00 @christian-ramos-tecnativa
[IMP] pos_user_restriction: Restrict POS report orders
9912b89
@etobella @christian-ramos-tecnativa
[FIX] pos_user_restriction: Change tests, as they were colliding with…
84648bf 
… other modules
@OCA-git-bot @christian-ramos-tecnativa
[BOT] post-merge updates
9638034
@peluko00 @christian-ramos-tecnativa
[17.0][FIX] pos_user_restriction: Fix can't close session with POS As…
15e348a 
…signed User role
@OCA-git-bot @christian-ramos-tecnativa
[BOT] post-merge updates
4dfc48f
@christian-ramos-tecnativa
[IMP] pos_user_restriction: pre-commit auto fixes
8d91f6e
@christian-ramos-tecnativa christian-ramos-tecnativa changed the title [18.0][MIG] pos_user_restriction: Migration to version 18.0 [18.0][MIG][WIP] pos_user_restriction: Migration to version 18.0 Nov 11, 2025
@pedrobaeza
Copy link
Member

pedrobaeza commented Nov 12, 2025

/ocabot migration pos_user_restriction

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 12, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 12, 2025
Open
16 tasks
@christian-ramos-tecnativa
Copy link
Author

christian-ramos-tecnativa commented Nov 12, 2025

Tried the point_of_sale tests and it seems like something changed upstream that now is checking ir.module.module data in _load_pos_data:

Traceback (most recent call last):
File "/opt/odoo/auto/addons/point_of_sale/models/pos_session.py", line 183, in load_data
response[model] = self.env[model]._load_pos_data(response)
File "/opt/odoo/auto/addons/point_of_sale/models/ir_module_module.py", line 19, in _load_pos_data
'data': self.search_read(domain, fields, load=False),
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 6138, in search_read
records = self.search_fetch(domain or [], fields, offset=offset, limit=limit, order=order)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 1773, in search_fetch
query = self._search(domain, offset=offset, limit=limit, order=order or self._order)
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5807, in _search
self.browse().check_access('read')
File "/opt/odoo/custom/src/odoo/odoo/models.py", line 4439, in check_access
raise result1
odoo.exceptions.AccessError: You are not allowed to access 'Module' (ir.module.module) records.

This operation is allowed for the following groups:
- Administration/Settings

Contact your administrator to request access if necessary.

More info:
odoo/odoo#183540
Missing sudo in line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.