[18.0][ADD] maintenance_purchase_stock: New module#539
[18.0][ADD] maintenance_purchase_stock: New module#539christian-ramos-tecnativa wants to merge 2 commits intoOCA:18.0from
Conversation
78f245f to
637d6e3
Compare
|
Hello @christian-ramos-tecnativa only one suggestion: could you consider renaming this addon? At this repo there's already an addon called |
|
Hi @dalonsod, I see your point. However, in cases like this, users should refer to the module description to understand its purpose. For example, the maintenance_stock module handles consumptions, not a full integration with stock. |
4921d5a to
fa08aeb
Compare
bb07af0 to
0370fa0
Compare
|
Ready for review/merge |
| @api.depends("move_ids.state", "move_ids.product_uom", "move_ids.quantity") | ||
| def _compute_qty_received(self): | ||
| res = super()._compute_qty_received() | ||
| self.order_id._create_equipments() |
There was a problem hiding this comment.
This shouldn't be done on a computed field, as this computation may be done as a result of a onchange, and later discarded, so please intercept instead write.
Depends on:
@Tecnativa TT59744
@pedrobaeza @victoralmau