[17.0][MIG] maintenance_inspection

[edescalona]

@BinhexTeam

Based on

• [18.0][MIG] maintenance_inspection: Migration to 18.0 #521

[edescalona]

Hi, @ypapouin @etobella @mymage, if you could do a review, thank you.

[ypapouin]

You cannot re-use my PR as is. First, because I believe that action path has been introduced in 18.0, and secondly because Odoo 17.0 is using the legacy Kanban view.
You have to remove these two commits:

• [MIG] maintenance_inspection: Kanban view updated
• [IMP] maintenance_plan: Path added to action

[edescalona]

ping @ypapouin

[rrebollo]

Please consider my suggestions. Also, I think the last commit should be squashed.

[edescalona]

Please consider my suggestions. Also, I think the last commit should be squashed.

I think it would be better to leave that revert history as is, don't you think?

[rrebollo]

I think it would be better to leave that revert history as is, don't you think?

Let's see what others think about it

[edescalona]

I think it would be better to leave that revert history as is, don't you think?

Let's see what others think about it

I have no problem removing it; I just checked different pull requests and there are commits like that, but I'll proceed to remove it. Thanks.

[edescalona]

ping @rrebollo @etobella @ypapouin

[rrebollo]

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

[etobella]

One silly questions, a lot of the changed done in the migration should be in the 18 migration too, like the "readonly" fields or Command changes.

[ypapouin]

@edescalona , I previously wrote that you have to remove these two (non-squashed on purpose) commits to be compatible with 17.0:

• [MIG] maintenance_inspection: Kanban view updated
• [IMP] maintenance_plan: Path added to action
  But instead of doing it, you have reverted these commits changes directly in your "Migration to 17.0" commit. That's not how it should be done.

@etobella I can replicate code changes on my 18.0 PR since all requests are relevant.

Maybe it's more "clean" to make changes in the 18.0 PR and rebase this PR after that ?

[edescalona]

Hi @ypapouin , well I understand that either way would be fine to make the changes, either with reverts or directly in the migration configuration. I can do it in the most convenient way. @etobella , what do you think about that?

[mymage]

Functional OK

[etobella]

@edescalona if some commits were splitted on purpose so you don't need to import it, please remove them.

[edescalona]

Hi @ypapouin , did you make the suggested changes in this migration to the 18 version? Can you confirm so I can perform the rebase again? Thanks.

[ypapouin]

Hi @edescalona, I'm on it right now

[ypapouin]

@edescalona , PR #521 is ready to rebase this one

Like before drop these commits:

• [MIG] maintenance_inspection: Kanban view updated
• [IMP] maintenance_plan: Path added to action

The last edit should be to rename list to tree

[edescalona]

Hi @ypapouin, thanks for letting me know.

[edescalona]

ping @ypapouin @etobella