Skip to content

[19.0][FIX] hr_employee_fistname error with permisions#1546

Merged
OCA-git-bot merged 1 commit intoOCA:19.0from
Studio73:19.0-fix-hr_employee_firstname
Apr 16, 2026
Merged

[19.0][FIX] hr_employee_fistname error with permisions#1546
OCA-git-bot merged 1 commit intoOCA:19.0from
Studio73:19.0-fix-hr_employee_firstname

Conversation

@Vicent-S73
Copy link
Copy Markdown

If the user are not in hr.group_hr_user but is in other group like hr_expense.group_hr_expense_manager if you try to go in, it raise this error because the fields defined in hr.employee are not defined in the public model and are not reachable

image

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hi @Savoir-faire Linux, @luisg123v,
some modules you are maintaining are being modified, check this out!

Copy link
Copy Markdown
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
thanks for this PR.
I don't thinks you need to bump teh release.
I think that's the CI/CD command that will bump the release.

Copy link
Copy Markdown
Contributor

@alexey-pelykh alexey-pelykh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. hr.employee.public needs these related fields to avoid access errors when non-HR users view employee data. Clean fix, CI is green. LGTM.

Minor: copyright header references Studio73 but the URL points to onestein.eu.

@Vicent-S73 Vicent-S73 force-pushed the 19.0-fix-hr_employee_firstname branch from 8c5caa6 to 51c92d0 Compare April 2, 2026 07:18
Copy link
Copy Markdown
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy code review
LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Saran440 Saran440 changed the title [FIX] hr_employee_fistname error with permisions [19.0][FIX] hr_employee_fistname error with permisions Apr 16, 2026
@Saran440
Copy link
Copy Markdown
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-1546-by-Saran440-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 049c846 into OCA:19.0 Apr 16, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 36aa624. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants