[19.0][FIX] hr_employee_fistname error with permisions#1546
[19.0][FIX] hr_employee_fistname error with permisions#1546OCA-git-bot merged 1 commit intoOCA:19.0from
Conversation
|
Hi @Savoir-faire Linux, @luisg123v, |
flotho
left a comment
There was a problem hiding this comment.
Hi,
thanks for this PR.
I don't thinks you need to bump teh release.
I think that's the CI/CD command that will bump the release.
alexey-pelykh
left a comment
There was a problem hiding this comment.
Good catch. hr.employee.public needs these related fields to avoid access errors when non-HR users view employee data. Clean fix, CI is green. LGTM.
Minor: copyright header references Studio73 but the URL points to onestein.eu.
8c5caa6 to
51c92d0
Compare
|
This PR has the |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 36aa624. Thanks a lot for contributing to OCA. ❤️ |
If the user are not in hr.group_hr_user but is in other group like hr_expense.group_hr_expense_manager if you try to go in, it raise this error because the fields defined in hr.employee are not defined in the public model and are not reachable