[16.0][MIG] website_sale_cart_selectable

[carmenbianca]

A fairly simple port of the module. I improved the documentation en passant.

Internal task: T12188

[polchampion]

successful functional test on the runboat

[polchampion]

functionaly tested on the runboat ; seems to work except there is an annoying error:

Uncaught Javascript Error > browser.navigator.clipboard is undefined

TypeError: browser.navigator.clipboard is undefined
    onClickClipboard@http://oca-e-commerce-16-0-pr977-d29370f00394.runboat.odoo-community.org/web/assets/604-1389ae2/1/web.assets_frontend_lazy.min.js:6767:20
    mainEventHandler@http://oca-e-commerce-16-0-pr977-d29370f00394.runboat.odoo-community.org/web/assets/604-1389ae2/1/web.assets_frontend_lazy.min.js:2074:77
    listener@http://oca-e-commerce-16-0-pr977-d29370f00394.runboat.odoo-community.org/web/assets/604-1389ae2/1/web.assets_frontend_lazy.min.js:1233:15
    ```

[huguesdk]

@polchampion i could not reproduce the error you mentioned, but i discovered another error that happens when the website_sale_stock module is installed along with this module. i fixed it. how to reproduce the other error?

[polchampion]

[edited - wrong pr]

[polchampion]

LGTM, couldn't reproduce the error

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[huguesdk]

@OCA/e-commerce-maintainers would someone please merge this?

[Honeyxilia]

LGTM (code review + tested on local instance)

[polchampion]

@OCA/e-commerce-maintainers would someone please merge this?

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[huguesdk]

@OCA/e-commerce-maintainers would someone please merge this?

[marcos-mendez]

Automated Review -- Tests Failed

1. Root Cause

The test failure is due to a database connection error (Connection to the database failed) during the Odoo server startup. This indicates that the test environment is misconfigured or the database is not accessible, not due to issues in the PR code itself.

2. Suggested Fix

There is no code fix required for the test failure, as it's a test environment issue, not a code issue. However, to ensure future tests run correctly, verify that:

• The database URL is correctly configured in the test environment.
• The PostgreSQL service is running and accessible.
• The odoo user has proper permissions to access the database.

3. Additional Code Issues

No real bugs found in the code changes. The module follows OCA patterns correctly:

• The website_btn_addtocart_published field is added to product.template as intended.
• The field is a boolean with default=True, which is standard.
• No override of extensibility hooks or incorrect use of modifiers.
• No use of deprecated patterns.

4. Test Improvements

To better test this module, consider adding the following test cases in a TransactionCase or SavepointCase:

a. Test Field Visibility in Product View

• Test: When website_btn_addtocart_published is set to False, the "Add to Cart" button should be hidden on the website.
• Pattern: Use self.env['product.template'].create(...) and assert view rendering or button visibility via JS or DOM inspection.

b. Test Default Value

• Test: Newly created product templates should have website_btn_addtocart_published=True by default.
• Pattern: Create a new product template and assert the default value.

c. Test Inheritance and Data Migration

• Test: Ensure the field is correctly inherited and accessible in both product.template and product.product.
• Pattern: Use self.env['product.product'] to check if the field is present and functional.

d. Test UI Toggle Behavior

• Test: The UI toggle should correctly update the field value.
• Pattern: Use self.env['product.template'].browse(...).write({'website_btn_addtocart_published': False}) and assert the change.

These tests should be tagged with @tag('post_install', 'manual') or @tag('website_sale') to align with OCA testing practices.

---

⚠️ PR Aging Alert: CRITICAL

This PR by @carmenbianca has been waiting for 509 days — that is over 16 months without being merged or closed.

Every ignored PR is a contributor who might not come back. Review time matters. (OCA Aging Report)

---

Reciprocal Review Request

Hi everyone! I found some test failures on this PR and left detailed feedback above. I am happy to discuss or help debug. In the meantime, if any of you get a chance, I would appreciate a look at my open PR(s):

My open PRs across OCA:

• server-tools#3554 [MIG] datetime_formatter: Migration to 18.0
• server-tools#3548 [18.0][MIG] base_kanban_stage: Migration to 18.0
• hr-attendance#262 [16.0][ADD] Hr_attendance_idsecure: iDSecure (ControliD) attendance integration
• stock-logistics-workflow#2276 [16.0][ADD] stock_move_line_devaluation
• stock-logistics-workflow#2275 [16.0][ADD] Stock move line analytic account
• stock-logistics-workflow#2268 [16.0][ADD] stock_move_line_picking_partner
• purchase-workflow#2694 [16.0][IMP]Purchase workflow added to review state & exception fix

Reviewing each other's work helps the whole community move forward. Thank you!

---

Environment via OCA Neural Reviewer: Minikube + K8s Job + oca-ci/py3.10-odoo16.0 | Odoo 16.0
Automated review by OCA Neural Reviewer + qwen3-coder:30b