[18.0][IMP] contract: fix invoicing (date_ref & invoice lines)#1403
Merged
OCA-git-bot merged 2 commits intoOCA:18.0from Mar 18, 2026
Merged
[18.0][IMP] contract: fix invoicing (date_ref & invoice lines)#1403OCA-git-bot merged 2 commits intoOCA:18.0from
OCA-git-bot merged 2 commits intoOCA:18.0from
Conversation
Allow to hook contract._prepare_invoice to add more invoice lines
Fix date_ref when invoicing multiple contracts
jbaudoux
force-pushed
the
18-fix-contract-invoice_line_ids
branch
from
daabf9f to
6276c8c
Compare
jbaudoux
changed the title
jbaudoux
changed the title
Contributor
Author
|
@luisDIXMIT @sbejaoui @etobella @pedrobaeza @victor-champonnois @tobiaszehntner I fixed the invoicing in case there are multiple contracts being invoiced. The date_ref method argument was overriden by the first contract. |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
This PR has the |
Contributor
|
Congratulations, your PR was merged at 9caa33b. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple contracts invoicing
Fix date_ref set by the first contract, preventing other contracts to be invoiced
Allow additional invoice lines
Allow to hook
contract._prepare_invoiceto add more invoice lines.invoice_vals["invoice_line_ids"]is already initialized by_prepare_invoice. I'm simply removing the reset of the value by the caller.