Skip to content

[16.0][IMP] Add a hook to enrich domain in get lines for the cutoff#342

Open
lmarion-source wants to merge 1 commit intoOCA:16.0from
acsone:16.0-cutoff_get_lines_domain_hook
Open

[16.0][IMP] Add a hook to enrich domain in get lines for the cutoff#342
lmarion-source wants to merge 1 commit intoOCA:16.0from
acsone:16.0-cutoff_get_lines_domain_hook

Conversation

@lmarion-source
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

Copy link

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add module name in commit msg
otherwise looks good

@lmarion-source lmarion-source force-pushed the 16.0-cutoff_get_lines_domain_hook branch from 808e8c8 to 30d125f Compare September 15, 2025 07:52
Copy link

@SirPyTech SirPyTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Only code review, looks good

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 18, 2026
@SirPyTech
Copy link

@jbaudoux please update your review.

@alexis-via as the module maintainer, what do you think of this change? Thanks!

@alexis-via
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-342-by-alexis-via-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 19, 2026
Signed-off-by alexis-via
@alexis-via alexis-via changed the title [IMP] Add a hook to enrich domain in get lines for the cutoff [16.0][IMP] Add a hook to enrich domain in get lines for the cutoff Jan 19, 2026
@OCA-git-bot
Copy link
Contributor

@alexis-via your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-342-by-alexis-via-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants