-
-
Notifications
You must be signed in to change notification settings - Fork 429
[19.0][MIG] sale_analytic_tag: Migration to version 19.0 #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cristina-hidalgo-tecnativa
wants to merge
8
commits into
OCA:19.0
Choose a base branch
from
Tecnativa:19.0-mig-sale_analytic_tag
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[19.0][MIG] sale_analytic_tag: Migration to version 19.0 #866
cristina-hidalgo-tecnativa
wants to merge
8
commits into
OCA:19.0
from
Tecnativa:19.0-mig-sale_analytic_tag
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT42276 [UPD] Update sale_analytic_tag.pot [BOT] post-merge updates
Translated using Weblate (Italian) Currently translated at 100.0% (2 of 2 strings) Translation: account-analytic-16.0/account-analytic-16.0-sale_analytic_tag Translate-URL: https://translation.odoo-community.org/projects/account-analytic-16-0/account-analytic-16-0-sale_analytic_tag/it/
Since odoo/odoo@d0342c8, the default existing company is not getting a CoA automatically, provoking than the current tests fail with the error: odoo.exceptions.UserError: No journal could be found in company My Company (San Francisco) for any of those types: sale Thus, we put tests post-install for being sure localization modules are installed, the same as AccountTestInvoicingCommon does, but we don't inherit from it, as it creates an overhead creating 2 new companies and loading their CoA and some more stuff, while we don't need all of that. Besides, if you don't have `l10n_generic_coa` installed, you can't use another CoA (like `l10n_es`) easily, so we put little code to select the first available CoA. [BOT] post-merge updates
[UPD] Update sale_analytic_tag.pot [BOT] post-merge updates
ec4eab1 to
dbbf780
Compare
Member
|
/ocabot migration sale_analytic_tag |
pedrobaeza
approved these changes
Jan 16, 2026
Member
pedrobaeza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can squash administrative commits into the one that generates them:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests
dbbf780 to
f544f08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration
@Tecnativa TT60289
@pedrobaeza @christian-ramos-tecnativa