[18.0][FIX] pos_analytic_by_config #841
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Oct 13, 2025
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
I don't really get the problem, and it would be advisable:
- Put comments on the code on what and why that 2 overrides.
- Put a regression test checking what this patch is fixing.
andrel-exo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR #831 fixed the issue where analytic distributions intended only for POS were also being applied in the backend.
However, it introduced a side effect: analytic lines started being created in flows where they shouldn’t (e.g. POS payments and session closing).
The root cause was that the _get_default_search_domain_vals method was missing. Without it, the POS-scoped models were still being matched globally in Odoo 18, since the analytic engine only filters on keys present in vals.
This new PR restores the original logic but also defines _get_default_search_domain_vals with
{"pos_config_id": False}.