-
-
Notifications
You must be signed in to change notification settings - Fork 429
[18.0][ADD] account_analytic #826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
dd5257a to
7cbc773
Compare
luisDIXMIT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runboat and LGTM!! Just fix what was commented.
| name="analytic_distribution" | ||
| widget="analytic_distribution" | ||
| groups="analytic.group_analytic_accounting" | ||
| readonly="state in ('done', 'cancel')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selection 'done' doesn't exists in state fields.
luisDIXMIT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test are failing.
6199839 to
70a3991
Compare
d08395a to
eaaf8f4
Compare
flotho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for this PR
IMHO the module name is not appropriate because it could cause confusion with native odoo even if it's not exactly the same.
Regards
This module is based on
purchase_analyticsand adapts the same functionality for account move.The goal of this module is to ease analytic distribution management on account move. This module add analytic distribution on account move.
If all lines of the account move have the same analytic distribution, the analytic distribution on the account move is automatically set with this value. If an analytic distribution is set on the account move, all lines of the account move will take this value.