[18.0][ADD] sale_analytic #825
Open
+786
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrel-exo
force-pushed
the
18.0_sale_analytic
branch
from
e55bab1 to
6b0864b
Compare
luisDIXMIT
approved these changes
Sep 1, 2025
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Tested on runboat and LGTM!! Just fix what was commented.
|
Good job @andrel-exo , but squash both commits into one. I think it’s more appropriate in order to make the history cleaner. |
andrel-exo
force-pushed
the
18.0_sale_analytic
branch
from
f03f982 to
6d5ace8
Compare
Contributor
|
Could you fix the test pipeline? |
|
Hi @andrel-exo, Thanks for this PR. Just one suggestion: it would be nice to also add the Also, as @ThiagoMForgeFlow mentioned, there seems to be a failing test but the logs have expired. Could you please re-trigger the CI so we can check if everything is passing now? Thanks! |
JoanSForgeFlow
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is based on
purchase_analyticsand adapts the same functionality for sale orders.The goal of this module is to ease analytic distribution management on
sale order. This module add analytic distribution on sale order.
If all lines of the sale order have the same analytic distribution, the
analytic distribution on the sale order is automatically set with this
value. If a analytic distribution is set on the sale order, all lines of
the sale will take this value.