Skip to content

Conversation

@AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Aug 27, 2025

This module adds a sequence field to analytic plans and uses it to control their display order in the analytic_distribution. When a plan’s sequence changes, the list is re-sorted accordingly.

@qrtl QT5688

Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional and code review

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_plan_sequence branch from 96449e3 to 7785b38 Compare August 27, 2025 08:56
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and functional test. 👍

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_plan_sequence branch from 7785b38 to 31ef543 Compare August 27, 2025 09:26
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and LGTM, just a minor suggestion

@AungKoKoLin1997
Copy link
Contributor Author

@oca/account-analytic-maintainers
Could you please take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants