[18.0] [MIG] analytic_partner: Migration to 18.0 #823
Conversation
|
Hi @AmalBenAissa |
flotho
left a comment
flotho
left a comment
There was a problem hiding this comment.
I've installed the module here http://oca-account-analytic-18-0-pr823-611933295916.runboat.odoo-community.org/odoo/action-286 but I'm not able to reach the analytic lines.
could you elaborate the README and the process.
Otherwise, the code LGTM
analytic_partner/README.rst
Outdated
| Usage | ||
| ===== | ||
|
|
||
| 1. Go to **Invoicing > Accounting > Management > Analytic Items**. |
There was a problem hiding this comment.
You're right, Management section doesn't exist.
There was a problem hiding this comment.
updated this instruction in readme file
| type="action" | ||
| name="%(act_analytic_cost_revenue)d" | ||
| icon="fa-usd" | ||
| string="Cost/Revenue" |
There was a problem hiding this comment.
Could you add default values in the context so that create will be eased during the creation
AmalBenAissa
force-pushed
the
18.0-mig-analytic_partner
branch
from
6119332 to
ff26ba1
Compare
hello @DorianMAG thanks for the request that is done |
luisDIXMIT
left a comment
luisDIXMIT
left a comment
There was a problem hiding this comment.
Tested on runboat and LGTM, just change the PR title to "[18.0] [MIG] analytic_partner: Migration to 18.0". It's a convenion to easily search it and identify.
AmalBenAissa
changed the title
[MIG] analytic_partner : Migration to 18.0 [MIG] analytic_partner : Migration to 18.0 update readme file
AmalBenAissa
force-pushed
the
18.0-mig-analytic_partner
branch
from
d2168b2 to
9676278
Compare
flotho
left a comment
flotho
left a comment
There was a problem hiding this comment.
Tested on runboat.
Doc is Ok, y bad
LGTM
|
ping @OCA/accounting-maintainers any chance to have a merge here ? |
DorianMAG
left a comment
DorianMAG
left a comment
There was a problem hiding this comment.
Functional test.
LGTM
Thx for this work
Saran440
left a comment
Saran440
left a comment
There was a problem hiding this comment.
Please check commit, It must have history commit.
|
ping @AmalBenAissa , some changes are requested, could you fix SVP ? |
Classify analytic items by partner ================================== This module adds a partner on each analytic item for allowing to have another dimension for analysing data. It also handles the proper propagation of this field to the created analytic entries when validating invoices. Configuration ============= You have to be granted as at least "Accountant" in your user profile and have checked the "Analytic Accounting" access right. Usage ===== Go to Accounting > Analytic Journal Items, and there, you can set the partner for the analytic items, and search or group by it. You can also go to a partner, and click on the smart-button "Cost/Revenue", placed on the upper-right part, and you will navigate to the analytic items associated to this partner. Known issues / Roadmap ====================== * This module hasn't been tested with *account_analytic_plans* module installed, so maybe it's incompatible with it.
* IMP: Distinguish between the partner of the account and the specific partner * FIX: Allow grouping on partner_id field. Fixes OCA#41 * FIX: README - Indentation is not correct in Known issues.
|
@Saran440 done , could you check please ? |
|
@AmalBenAissa Thanks for the fix. Please read the instructions here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0#how-to |
|
Hi @Saran440, Could you clarify the problem? It seems the history was preserved correctly. Best regards |
|
Could you clarify the problem?
Is it necessary to squash the last commit?
However, if the maintainer is fine with this PR, I’m fine with it too. |
16 participants
Migration module analytic_partner to version 18.0