Skip to content

[16.0][ADD] account_analytic_relation_filter #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AungKoKoLin1997 wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] account_analytic_relation_filter #809

AungKoKoLin1997 wants to merge 1 commit into from
+932 −0

Conversation

@AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Jul 25, 2025

This module introduces a filter for the analytic_distribution field by establishing a relation between analytic accounts.

@qrtl QT5540

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch 2 times, most recently from 0d2d05c to 3c14761 Compare July 25, 2025 09:22
kanda999
kanda999 reviewed Jul 31, 2025
View reviewed changes
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch from 3c14761 to 8e4b355 Compare July 31, 2025 07:24
@AungKoKoLin1997 AungKoKoLin1997 requested a review from kanda999 July 31, 2025 07:29
kanda999
kanda999 approved these changes Jul 31, 2025
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch from 8e4b355 to a72c0c7 Compare August 1, 2025 09:50
yostashiro
yostashiro reviewed Aug 1, 2025
View reviewed changes
yostashiro
yostashiro reviewed Aug 1, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name suggestion: account_analytic_relation_filter

yostashiro
yostashiro approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@AungKoKoLin1997 AungKoKoLin1997 changed the title [16.0][ADD] analytic_distribution_filter [16.0][ADD] account_analytic_relation_filter Aug 4, 2025
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch 3 times, most recently from 83728e4 to 3a35a2e Compare August 4, 2025 09:08
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch from 3a35a2e to b4a47ec Compare August 14, 2025 09:57
@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Aug 14, 2025 •
edited
Loading

@yostashiro @kanda999 I make some adjustments to work the filter even when we select the accounts from the search more... as well and some JS code improvements.

@yostashiro
Copy link
Member

yostashiro commented Aug 15, 2025

Filter doesn't seem to be applied in some situations.

"Internal" department is linked to two projects.
image

"Internal" department has been selected for a record and the record has been saved.
image

No filter is applied to projects (which is not as expected).
image

Once I open the search modal and close it, the filter is applied correctly.
image

@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Aug 15, 2025

Filter doesn't seem to be applied in some situations.

@yostashiro I fixed it.

@yostashiro
Copy link
Member

yostashiro commented Aug 15, 2025

Not sure where it's coming from but I get a client error when I try to select an analytic account for saved records.
image

yostashiro
yostashiro approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The JS error I reported doesn't seem to reproduce now.

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 15, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

kanda999
kanda999 approved these changes Aug 20, 2025
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: it works as expected

@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Sep 1, 2025

@oca/account-analytic-maintainers
Could you please take a look at this PR?

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch from 8de3731 to 6344af2 Compare September 26, 2025 02:24
@AungKoKoLin1997
Copy link
Contributor Author

AungKoKoLin1997 commented Sep 29, 2025

My latest commit is to fix the crash that happened because our patch was still awaiting an RPC result (orm.call) after the component had already been destroyed (for example, when a UserError interrupted the form creation). When that happens, OWL raises “Component is destroyed”.

@github-actions
Copy link

github-actions bot commented Feb 1, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 1, 2026
kanda999
kanda999 approved these changes Feb 2, 2026
View reviewed changes
Copy link

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: It’s still working on the production server.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-analytic_distribution_filter branch from 6344af2 to 873e026 Compare February 2, 2026 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@yostashiro yostashiro yostashiro approved these changes

@kanda999 kanda999 kanda999 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AungKoKoLin1997 @yostashiro @OCA-git-bot @kanda999