-
Notifications
You must be signed in to change notification settings - Fork 101
update references to 3.1.0 #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
handrews
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karenetheridge thanks again for working on the Learn site! I went through all of the non-.dot files in detail.
I started fixing broken camelCase links (not broken because of your change), but once i finished the non-.dot files and went back to check those, I realized it was a much bigger effort and perhaps a bit of search-and-replace on your end might be better than me clicking through 100 or so more GitHub suggestions. Or we can do these as a separate fix later.
I did check on the links to sections that weren't Object headings, and the few present here are indeed still present in 3.2.
|
I was actually going to suggest that we have a script (perhaps driven by a GH action) that extracts all the spec links from the learn site and adds them to a list to check that they keep existing. ;) |
cafb997 to
b39608f
Compare
|
New commits pushed which correct the bad links. |
via:
perl -p -i -e's{/oas/latest#\K([a-zA-Z]+)\b}{lc join("-", split /(?=[A-Z])/, $1)}ge' `find * -type f`
via: perl -p -i -e's/oas-object/openapi-object/g' `find * -type f`
a3c68c4 to
2414550
Compare
|
I can add a linkchecker if that's useful? We might even already have a ticket open and I just didn't actually do it yet .... |
|
I had a linkchecker running locally that exercises all the links to check for a 404, but the problem in this case is that the anchor links were wrong, which requires having the local document in hand to check that the anchor goes to a defined location within the document. |
No description provided.