feat: add EFF list

[Noxsios]

• add eff download
• fix gen
• mvp
• more renames
• start benchmarking for fun and no profit
• enum flag
• enum flag fixed
• fix lint

[Copilot]

Pull request overview

This PR adds support for the EFF (Electronic Frontier Foundation) wordlist as an alternative to the existing system dictionary wordlist for password generation. The implementation includes a new dice-rolling mechanism for EFF word selection and makes the wordlist choice configurable via command-line flag.

Key changes:

• Added EFF wordlist support with dice-roll based word selection
• Introduced a Wordlist enum type with flag binding for choosing between wordlists
• Refactored existing code to support multiple wordlist backends

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
words/wordlist.go	Defines new Wordlist enum type with pflag.Value implementation for CLI flag binding
words/roll_five_dice.go	Implements cryptographic dice rolling for EFF wordlist selection
words/roll_five_dice_test.go	Comprehensive test suite for dice rolling functionality
words/ezpass.go	Adds PrintEzpassEFF function and renames variable from ALL to USR_SHARE_DICT
words/gen_usr_share_dict.go	Updates generated variable name from ALL to USR_SHARE_DICT
gen/main.go	Extends generator to download and generate EFF wordlist alongside existing dictionary
cmd/root.go	Adds wordlist flag and switches between wordlist implementations
cmd/good.txtar	Updates expected usage output to include new wordlist flag
Makefile	Adds benchmark target for performance testing
.golangci.yaml	Disables cyclop linter

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The benchmark function is named BenchmarkRoll6Dice but it benchmarks Roll5Dice. This should be renamed to BenchmarkRoll5Dice to match the function being tested.

Suggested change

	func BenchmarkRoll6Dice(b *testing.B) {
	func BenchmarkRoll5Dice(b *testing.B) {

[Copilot]

The benchmark name BenchmarkRoll6Dice is incorrect - it should be BenchmarkRoll5Dice to match the actual benchmark function name (once Comment 1 is fixed).

Suggested change

	go test ./words -bench BenchmarkRoll6Dice -benchmem
	go test ./words -bench BenchmarkRoll5Dice -benchmem

[Copilot]

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated 7 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.