openapi-generator-cli: 7.18.0 -> 7.21.0#483728
Conversation
|
|
B4dM4n
left a comment
There was a problem hiding this comment.
Looks good now.
Code generation for -g typescript-fetch and -g go works as expected.
|
Sadly, the I did find the old version on another machine, so I could compare them: diff -ru /nix/store/fy70ffs137cp2vyz0cb6fcvap8qln6pl-maven-deps-openapi-generator-cli-7.19.0/.m2 /nix/store/facbcga031ni50lw721hzhsc1rli9xkp-maven-deps-openapi-generator-cli-7.19.0/.m2
Only in /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension: 2.3.3
Only in /nix/store/fa…kp-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension: 2.3.4
diff -ru /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml /nix/store/fa…kp-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml
--- /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml 1970-01-01 01:00:01.000000000 +0100
+++ /nix/store/fa…kp-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml 1970-01-01 01:00:01.000000000 +0100
@@ -3,8 +3,8 @@
<groupId>com.gradle</groupId>
<artifactId>develocity-maven-extension</artifactId>
<versioning>
- <latest>2.3.3</latest>
- <release>2.3.3</release>
+ <latest>2.3.4</latest>
+ <release>2.3.4</release>
<versions>
<version>1.21</version>
<version>1.21.1</version>
@@ -29,7 +29,8 @@
<version>2.3.1</version>
<version>2.3.2</version>
<version>2.3.3</version>
+ <version>2.3.4</version>
</versions>
- <lastUpdated>20260128144206</lastUpdated>
+ <lastUpdated>20260211105713</lastUpdated>
</versioning>
</metadata>
diff -ru /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml.sha1 /nix/store/fa…kp-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml.sha1
--- /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml.sha1 1970-01-01 01:00:01.000000000 +0100
+++ /nix/store/fa…kp-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension/maven-metadata-central.xml.sha1 1970-01-01 01:00:01.000000000 +0100
@@ -1 +1 @@
-d410c5d24945f9c304eb4481be296d5dda02af9c
\ No newline at end of file
+4fc2ea031df4e21684930894a876752cbed49255
\ No newline at end of fileI'm not experienced in using maven, but this is what I can tell from the diff: During the dependency cache build, maven fetched the latest version information for Digging into the https://github.com/OpenAPITools/openapi-generator/blob/v7.19.0/.mvn/extensions.xml#L4-L6 and specifies version https://github.com/OpenAPITools/openapi-generator/blob/v7.19.0/pom.xml#L408-L422 without any version requirement (which is normal from what I found on the internet), but this seems to prompt maven to fetch the latest version from the internet. So By adding diff --git a/pkgs/by-name/op/openapi-generator-cli/package.nix b/pkgs/by-name/op/openapi-generator-cli/package.nix
index 10c3dc76ac9e..acd79d7a43b6 100644
--- a/pkgs/by-name/op/openapi-generator-cli/package.nix
+++ b/pkgs/by-name/op/openapi-generator-cli/package.nix
@@ -24,7 +24,15 @@ let
hash = "sha256-16fkBz2TndueBzYq0pLxhxFxxZfF9WsmxQjKzeiqZcU=";
};
- mvnHash = "sha256-FlvP8Lx6J74iJCd8xe8JEzE4U6Q9BtZUMLz+BeuPOVE=";
+ postPatch = ''
+ # specifying any version number prevents maven from trying to find the latest one
+ # the real version is defined in `.mvn/extensions.xml`
+ substituteInPlace pom.xml \
+ --replace-fail '<artifactId>develocity-maven-extension</artifactId>' \
+ '<artifactId>develocity-maven-extension</artifactId><version>0</version>'
+ '';
+
+ mvnHash = "sha256-xENwliF8E7QR6O6kubLVN6oFUcprxNzH/7NzBun4XPE=";
mvnParameters = "-Duser.home=$TMPDIR";
doCheck = false;
Resulting changes in the diff -ru /nix/store/fy70ffs137cp2vyz0cb6fcvap8qln6pl-maven-deps-openapi-generator-cli-7.19.0/.m2 /nix/store/l6gwajyabi86ngsldf18z2lgqdzcqmyx-maven-deps-openapi-generator-cli-7.19.0/.m2
Only in /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension: 2.3.3
Only in /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension: maven-metadata-central.xml
Only in /nix/store/fy…pl-maven-deps-openapi-generator-cli-7.19.0/.m2/com/gradle/develocity-maven-extension: maven-metadata-central.xml.sha1This raises the question: should |
|
I've crafted a |
|
|
Upstream PR to add a pin: OpenAPITools/openapi-generator#23326 |
|
Upstream fix merged. The release cadence seems to be monthly and they just released 7.21.0 a few hours ago, so 7.22.0 will probably land mid-April. |
|
I will |
|
Pull request was closed
Fixes #505996
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.