Skip to content

Comments

Add init status EFS_FLASH_NEED_REFORMAT#72

Merged
robin-nitrokey merged 2 commits intomainfrom
init-status-efs-need-reformat
Jul 25, 2025
Merged

Add init status EFS_FLASH_NEED_REFORMAT#72
robin-nitrokey merged 2 commits intomainfrom
init-status-efs-need-reformat

Conversation

@sosthene-nitrokey
Copy link
Contributor

@sosthene-nitrokey sosthene-nitrokey commented May 7, 2025

@sosthene-nitrokey sosthene-nitrokey force-pushed the init-status-efs-need-reformat branch 2 times, most recently from 13d52f8 to 4206bee Compare May 12, 2025 08:54
Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the changelog and bump the package version.

@sosthene-nitrokey sosthene-nitrokey force-pushed the init-status-efs-need-reformat branch from ac47ca6 to 3e4e7a9 Compare May 12, 2025 15:14
@sosthene-nitrokey
Copy link
Contributor Author

I thought it was a non-breaking change but it is. Is there anything else we want to include?

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don’t have anything else to include in the release.

CHANGELOG.md Outdated

## [v0.4.0](https://github.com/Nitrokey/nitrokey-sdk-py/releases/tag/v0.3.2) (2025-05-12)

- `nitrokey.trussed.admin_app.InitStatus`: add support for returning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `nitrokey.trussed.admin_app.InitStatus`: add support for returning
- `nitrokey.trussed.admin_app.InitStatus`: add `EXT_FLASH_NEED_REFORMAT` variant

@sosthene-nitrokey sosthene-nitrokey force-pushed the init-status-efs-need-reformat branch from 3e4e7a9 to 48f1826 Compare May 12, 2025 15:38
@robin-nitrokey
Copy link
Member

@sosthene-nitrokey If you don’t mind I’ll merge this PR without the release commit so that we can include the NKPK changes in the release.

@robin-nitrokey robin-nitrokey force-pushed the init-status-efs-need-reformat branch from 48f1826 to f67282e Compare July 25, 2025 12:25
@sosthene-nitrokey
Copy link
Contributor Author

Yes

@robin-nitrokey robin-nitrokey merged commit f67282e into main Jul 25, 2025
40 checks passed
@robin-nitrokey robin-nitrokey deleted the init-status-efs-need-reformat branch July 25, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants