Skip to content

Conversation

@ienaga
Copy link
Member

@ienaga ienaga commented Dec 1, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 1, 2025 23:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions workflow configurations to standardize Node.js version and ensure the latest npm version is used across all workflows, along with a package version bump.

  • Standardizes Node.js version to 24 across all workflow jobs
  • Adds explicit npm upgrade step to ensure latest npm version is used
  • Bumps package version from 0.0.23 to 0.0.24

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Version bump from 0.0.23 to 0.0.24
.github/workflows/publish.yml Adds npm upgrade step before installation
.github/workflows/lint.yml Standardizes Node.js version to 24 and adds npm upgrade step for both macOS and Windows test jobs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- uses: actions/setup-node@v6
with:
node-version: 24
registry-url: "https://registry.npmjs.org"
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry-url configuration is unnecessary for the lint workflow since it's only used when publishing to npm. This configuration is needed in publish.yml but not in lint.yml. Consider removing this line to keep the workflow configuration minimal and clear.

Copilot uses AI. Check for mistakes.
- uses: actions/setup-node@v6
with:
node-version: 24
registry-url: "https://registry.npmjs.org"
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The registry-url configuration is unnecessary for the lint workflow since it's only used when publishing to npm. This configuration is needed in publish.yml but not in lint.yml. Consider removing this line to keep the workflow configuration minimal and clear.

Copilot uses AI. Check for mistakes.
@ienaga ienaga merged commit b76cbc4 into main Dec 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants