fix(ntp): align cpp17 guard macro #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_TIME_SHIELD_CPP17guard with the publicTIME_SHIELD_CPP17ininclude/time_shield/ntp_time_service.hpp.extern/definition and the inline/static singleton paths to follow the same standard check.Testing
cmake -S . -B build-cpp11 -DCMAKE_CXX_STANDARD=11 -DTIME_SHIELD_CPP_BUILD_TESTS=ON,cmake --build build-cpp11andctest --test-dir build-cpp11, and all tests passed.cmake -S . -B build-cpp14 -DCMAKE_CXX_STANDARD=14 -DTIME_SHIELD_CPP_BUILD_TESTS=ON,cmake --build build-cpp14andctest --test-dir build-cpp14, and all tests passed.cmake -S . -B build-cpp17 -DCMAKE_CXX_STANDARD=17 -DTIME_SHIELD_CPP_BUILD_TESTS=ON,cmake --build build-cpp17andctest --test-dir build-cpp17, and all tests passed (100% of tests).Codex Task