Codex-generated pull request #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update MAX_TIMESTAMP to avoid ms overflow and extend boundary tests for negative and ms timestamps.
Reduce the maximum timestamp to keep year-end conversions in range for millisecond calculations.
Return the last millisecond of the year to match end-of-year expectations and update coverage assertions.
Wrap numeric_limits min/max in parentheses to prevent Windows macro expansion in timestamp checks.
NewYaroslav
deleted the
codex/add-tests-for-start_of_year-and-end_of_year
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task