Skip to content

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Dec 18, 2025

Adds a workaround for a bug where neurodata types are incorrectly assigned the 'hdmf-experimental' namespace instead of 'hdmf-common'. If a MATLAB class does not exist for 'hdmf-experimental' but does for 'hdmf-common', the namespace and typename are corrected accordingly on read

See hdmf-dev/hdmf#1347 for details.

Motivation

Support read for files affected by the issue described above

How to test the behavior?

N/A

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

Adds a workaround for a bug where neurodata types are incorrectly assigned the 'hdmf-experimental' namespace instead of 'hdmf-common'. If the class does not exist for 'hdmf-experimental' but does for 'hdmf-common', the namespace and typename are corrected accordingly. See hdmf-dev/hdmf#1347 for details.
@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (08da374) to head (b75d457).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #779      +/-   ##
==========================================
+ Coverage   95.50%   95.53%   +0.02%     
==========================================
  Files         191      191              
  Lines        6922     6938      +16     
==========================================
+ Hits         6611     6628      +17     
+ Misses        311      310       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ehennestad ehennestad requested a review from bendichter January 13, 2026 13:58
@bendichter
Copy link
Contributor

why are all the tests failing?

@bendichter bendichter merged commit b285920 into main Jan 13, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants