changed the saved params for the impression preprocessing #90
+22
−185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff CoverageDiff: origin/main..HEAD, staged and unstaged changes
Summary
|
Minimum allowed line rate is |
jokkalt
approved these changes
Jan 19, 2026
| mark.meta_data.update( | ||
| _build_preprocessing_metadata(params, mark.center, is_resampled) | ||
| ) | ||
| mark.meta_data.update(**asdict(params)) |
There was a problem hiding this comment.
Bit of a noob question; why can we just use .update here, but use the model_copy(update=...) in utils.py update_mark_* functions?
| assert center_x == pytest.approx(50e-6) | ||
| assert center_y == pytest.approx(50e-6) | ||
| center_x, center_y = filtered.center | ||
| assert center_x == pytest.approx(40.5) |
There was a problem hiding this comment.
Why have these values changed? It feels that removing parameters from a meta data field should not change the overall outcome.
Either way: the comment on line 543 is now wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after discussions we decided we need to save fewer params for the preprocessing of the impression marks