Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the ONTAP MCP toolset to manage NVMe subsystems (create/update/delete) and NVMe subsystem hosts (add/remove), while consolidating existing NVMe service logic into shared nvme.go files across server and REST layers.
Changes:
- Added new tool schemas + MCP tool registrations for NVMe subsystem and subsystem-host operations.
- Implemented server handlers and REST client methods for NVMe subsystem CRUD and host add/remove.
- Updated integration tests and documentation examples to cover the new NVMe subsystem workflows.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| tool/tool.go | Adds tool parameter structs for NVMe subsystem and host operations. |
| server/server.go | Registers new MCP tools for NVMe subsystem and host actions. |
| server/nvme.go | Consolidates NVMe service logic and adds subsystem/host handlers + validators. |
| rest/nvme.go | Consolidates NVMe REST client code and adds subsystem/host REST calls. |
| ontap/ontap.go | Adds ONTAP model structs for NVMe subsystem and host payloads. |
| integration/test/nvme_test.go | Adds/expands integration coverage for NVMe service + subsystem flows. |
| docs/examples.md | Adds example prompts/responses for NVMe subsystem and host operations. |
| descriptions/descriptions.go | Adds tool descriptions for the new NVMe subsystem/host tools. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # integration/test/nvme_service_test.go
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
# Conflicts: # descriptions/descriptions.go # ontap/ontap.go # server/server.go # tool/tool.go
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.