feat: add queueDepth for volume eseries#4227
Merged
rahulguptajss merged 4 commits intomainfrom Apr 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new E-Series volume performance metrics (queue depth + other ops), wires them into the EseriesPerf collector as a derived metric, and updates the Grafana dashboard plus generated metric documentation/metadata accordingly.
Changes:
- Add
otherOps,queueDepthMax,queueDepthTotalcounters and derivequeue_depth_averageinEseriesPerf. - Update E-Series Volume Grafana dashboard with new panels for Other IOPs and Queue Depth (Avg/Max).
- Regenerate/update metric metadata + docs to include the new metrics and refresh creation dates.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| mcp/metadata/eseries_metrics.json | Adds HELP text entries for the new volume metrics. |
| grafana/dashboards/eseries/volume.json | Adds new panels/row for queue depth + other ops and updates dashboard export format. |
| docs/storagegrid-metrics.md | Refreshes generated “Creation Date”. |
| docs/ontap-metrics.md | Refreshes generated “Creation Date”. |
| docs/eseries-metrics.md | Documents the new E-Series volume metrics and their dashboard panels; refreshes “Creation Date”. |
| docs/cisco-switch-metrics.md | Refreshes generated “Creation Date”. |
| conf/eseriesperf/static_counter_definitions.yaml | Registers new REST counters (otherOps, queueDepthTotal, queueDepthMax) and types. |
| conf/eseriesperf/11.80.0/volume.yaml | Adds new counters needed for export + derived queue depth average calculation. |
| cmd/tools/generate/eseries_counter.yaml | Adds entries for the new metrics for the generator pipeline. |
| cmd/collectors/eseriesperf/eseriesperf.go | Implements derived queue_depth_average and hides queueDepthTotal from export. |
| cmd/collectors/eseriesperf/eseriesperf_test.go | Adds tests for the new derived metric logic/flag. |
| cmd/collectors/eseries/template.go | Extends object config to enable queue depth average calculation for volumes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Hardikl
previously approved these changes
Apr 8, 2026
cgrinds
reviewed
Apr 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.