Skip to content

Conversation

@Log1x
Copy link

@Log1x Log1x commented May 24, 2023

This fixes inaccurate descriptions being thrown in some cases when scraping apps in RTL languages.

This was notably an issue with Tumblr. I am not deep enough into my scrape yet to notice any other discrepancies, so I'm hoping this is it.

// Requires the fix, otherwise it will return the English description.
$apps->getAppInfoForLocales('com.tumblr', ['ar']);

// Description is in the proper place.
$apps->getAppInfoForLocales('com.instagram.android', ['ar']);

Not sure what makes Tumblr unique in this scenario, but with a test of 1000 apps in 13 languages, this fix has proved to work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant