Skip to content

Fix accurev excl in deep-hist migrations #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mr-scrawley wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix accurev excl in deep-hist migrations #125

mr-scrawley wants to merge 2 commits into from

Conversation

@mr-scrawley
Copy link

@mr-scrawley mr-scrawley commented Apr 1, 2025 •
edited
Loading

I understand that this will probably not get merged but I wanted to leave this here for future reference for folks encountering the issue.

  • removes the transaction type "defcomp", which is the result of accurev excl calls, from the list of ignored transaction types
  • removes performance optimization that was skipping pass-through streams altogether when collecting relevant transactions during deep-hist
    • Pass-through streams should not contain that many transactions anyway so this should not be a big performance hit.

Resolves #124

@mr-scrawley
stop ignoring defcomp transaction types
d899b14 
This ensures that elements excluded from a stream via `accurev excl`
will also be excluded in git starting from the associated commit.
@mr-scrawley
include pass-through streams during deep-hist
526f8d9 
Pass-through streams may contain transactions relevant for the source
code, e.g. if `accurev excl` is used on such a stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

accurev excl (excludes) are ignored in deep-hist migrations

1 participant

@mr-scrawley