Open
Conversation
added 30 commits
December 26, 2024 16:08
added 15 commits
May 27, 2025 10:06
mnblonsky
commented
Sep 2, 2025
Collaborator
Author
mnblonsky
left a comment
mnblonsky
left a comment
There was a problem hiding this comment.
Hey, sorry I just discovered another branch that we didn't have a PR for... Make sure you do the ResStock 2024 PR first, this has a bunch of code from that one. I've also been using this branch for the validation work.
This also hasn't been fully tested. I think we're waiting for HPXML files with PV/battery/EV in them before testing? It's been a while since I worked on this, so I'm not fully sure. There's probably a few docs things to update too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #164. Adds EV, PV, battery, and generator from HPXML. A few related fixes and updates:
Fixes issue with default PV azimuth (180=south is the default now)
Removes default parameters file for battery and generator and removes the
parameters_filefor equipment (wasn't in the docs). Parameters must be provided in the equipment arguments nowUpdates default EV fuel economy and allows it to be passed as an input.
Add default EV schedule parameters
Updates schedule columns to include "Electric Power" or "Gas Power" in the names. Doesn't impact input parameters or output variables.
Reference the issue your PR is fixing
Assign at least 1 reviewer for your PR
Test with run_dwelling.py or other script
Update documentation as appropriate
Update changelog as appropriate