push jupyterlab image #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvankrieken
force-pushed
the
fvk-jupyterlab
branch
from
07cc421 to
019adc7
Compare
Contributor
Author
|
Oh and I need to drop the "build on push" commit before merging to main - meant to just build on pushes to main but this was easier for development |
Contributor
I think the dev container is useful if you want to check out dcpy without Jupyter, no? |
Contributor
Author
I think though in that case it might be nicer to not use docker -> just activate your venv or whatever and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 liner to launch jupyterlab for this repo
docker run --rm -p 8888:8888 nycplanning/open_data_ingestShould we drop the dev container? Happy to go either way