Skip to content

Conversation

@fairywreath
Copy link
Contributor

Category

  • New feature
  • Bugfix
  • Breaking change
  • Refactoring
  • Documentation
  • Other (please explain)

Description

Adds support for Python's ast.IfExp in kernels. The codegen node visitor is modified to handle ast.IfExp by generating regular if statements.

Before your PR is "Ready for review"

  • All commits are signed-off to indicate that your contribution adheres to the Developer Certificate of Origin requirements
  • Necessary tests have been added
  • Documentation is up-to-date
  • Auto-generated files modified by compiling Warp and building the documentation have been updated (e.g. stubs.py, functions.rst)
  • Code passes formatting and linting checks with pre-commit run -a

@shi-eric shi-eric added this to the 1.8.0 milestone May 9, 2025
@shi-eric shi-eric added the language support Python language support label May 9, 2025
Copy link
Member

@christophercrouzet christophercrouzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great, thank you!

@christophercrouzet
Copy link
Member

Thanks again, your commits 08bec96 and 4a3b095 have been merged into main.

@fairywreath fairywreath deleted the ifexp branch May 19, 2025 00:28
@momo-van momo-van added the feature request Request for something to be added label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Request for something to be added language support Python language support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants