Mark include directories as SYSTEM for consuming targets#1977
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Apr 1, 2026
Merged
Mark include directories as SYSTEM for consuming targets#1977ericniebler merged 1 commit intoNVIDIA:mainfrom
ericniebler merged 1 commit intoNVIDIA:mainfrom
Conversation
When a project enables -Wreserved-identifier (as recommended by clang for production codebases), including stdexec headers generates >8000 warnings due to the __double_underscore naming convention used internally. These warnings are expected within stdexec itself but should not propagate to consumers. Adding SYSTEM to target_include_directories causes CMake to pass -isystem instead of -I for stdexec's include paths, suppressing warnings that originate from stdexec headers in consuming projects. This matches the convention used by other header-heavy libraries (Boost, fmt, spdlog) that use reserved identifiers internally. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
/ok to test ca3797c |
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project enables -Wreserved-identifier (as recommended by clang for production codebases), including stdexec headers generates >8000 warnings due to the __double_underscore naming convention used internally. These warnings are expected within stdexec itself but should not propagate to consumers.
Adding SYSTEM to target_include_directories causes CMake to pass -isystem instead of -I for stdexec's include paths, suppressing warnings that originate from stdexec headers in consuming projects.
This matches the convention used by other header-heavy libraries (Boost, fmt, spdlog) that use reserved identifiers internally.