Skip to content

Conversation

@eordentlich
Copy link
Collaborator

@eordentlich eordentlich commented Jan 20, 2026

fix #1006

to avoid nightly ci failures when new versions released.
We will need to update manually and reformat code as warranted.

Signed-off-by: Erik Ordentlich <[email protected]>
@eordentlich
Copy link
Collaborator Author

fixes #1006

@eordentlich
Copy link
Collaborator Author

build

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 20, 2026

Greptile Summary

Pinned black to version 25.12.0 and isort to 7.0.0 in development dependencies to prevent CI failures from automatic updates when new versions are released. Also updated copyright year to 2026.

  • Changed black>=23.1.0 to black==25.12.0
  • Changed isort>=5.12.0 to isort==7.0.0
  • Updated copyright year from 2025 to 2026

These formatting tools are used in ci/lint_python.py for code style checks. Pinning prevents breaking changes in new releases from causing unexpected CI failures.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal and well-scoped: pinning two development dependency versions and updating a copyright year. Pinning black and isort prevents unexpected CI failures from breaking changes in new releases, which is a best practice for CI stability. The selected versions (25.12.0 for black and 7.0.0 for isort) appear consistent with the project version 25.12.0. No logic changes, no production code affected.
  • No files require special attention

Important Files Changed

Filename Overview
python/requirements_dev.txt Pinned black to 25.12.0 and isort to 7.0.0 to prevent CI failures from new releases, updated copyright year to 2026

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant CI as CI System
    participant Pip as pip install
    participant Lint as lint_python.py
    participant Black as black
    participant Isort as isort

    Dev->>CI: Push code / PR
    CI->>Pip: Install requirements_dev.txt
    Pip->>Pip: Install black==25.12.0
    Pip->>Pip: Install isort==7.0.0
    CI->>Lint: Run formatting checks
    Lint->>Isort: isort --check --profile=black
    Isort-->>Lint: Check result
    Lint->>Black: black --check
    Black-->>Lint: Check result
    alt Formatting passes
        Lint-->>CI: Success
        CI-->>Dev: CI passes
    else Formatting fails
        Lint-->>CI: Failure with fix commands
        CI-->>Dev: CI fails - run formatters
    end
Loading

@eordentlich eordentlich merged commit 1d59f0f into NVIDIA:release/25.12 Jan 20, 2026
5 checks passed
@eordentlich eordentlich deleted the eo_pin_formatting branch January 20, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants