fix(uvm): check pRmApi->Control status in nvGpuOpsSetPageDirectory#1088
Open
sdimitro wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(uvm): check pRmApi->Control status in nvGpuOpsSetPageDirectory#1088sdimitro wants to merge 1 commit intoNVIDIA:mainfrom
sdimitro wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
nvGpuOpsSetPageDirectory unconditionally dereferences the return value of vaspaceGetPageDirBase() after calling pRmApi->Control() for NV0080_CTRL_CMD_DMA_SET_PAGE_DIRECTORY without checking the status. If the control call fails (e.g. due to GSP RPC resource exhaustion), the error cleanup path in deviceCtrlCmdDmaSetPageDirectory_IMPL calls gvaspaceExternalRootDirRevoke which sets pExternalPDB to NULL. The subsequent vaspaceGetPageDirBase() then returns NULL, and the call to memdescGetPhysAddr() triggers a kernel NULL pointer dereference. Add the missing status check after pRmApi->Control() and bail out with proper cleanup (re-enabling channels if externally owned, releasing locks, and freeing thread state) on failure. Signed-off-by: Serapheim Dimitropoulos <sdimitropoulos@coreweave.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvGpuOpsSetPageDirectory unconditionally dereferences the return value of vaspaceGetPageDirBase() after calling pRmApi->Control() for NV0080_CTRL_CMD_DMA_SET_PAGE_DIRECTORY without checking the status. If the control call fails (e.g. due to GSP RPC resource exhaustion), the error cleanup path in deviceCtrlCmdDmaSetPageDirectory_IMPL calls gvaspaceExternalRootDirRevoke which sets pExternalPDB to NULL. The subsequent vaspaceGetPageDirBase() then returns NULL, and the call to memdescGetPhysAddr() triggers a kernel NULL pointer dereference.
Add the missing status check after pRmApi->Control() and bail out with proper cleanup (re-enabling channels if externally owned, releasing locks, and freeing thread state) on failure.