Skip to content

Remove padding for page elements#1376

Draft
edknv wants to merge 3 commits intoNVIDIA:mainfrom
edknv:edwardk/remove-yolox-scaling-padding
Draft

Remove padding for page elements#1376
edknv wants to merge 3 commits intoNVIDIA:mainfrom
edknv:edwardk/remove-yolox-scaling-padding

Conversation

@edknv
Copy link
Collaborator

@edknv edknv commented Feb 4, 2026

Description

This PR removes padding from page element preprocessing. The padding_tuple parameter was originally required when the gRPC interface expected raw numpy arrays with uniform dimensions for batching. The interface has since moved to base64-encoded images, which handle variable-sized inputs natively.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • If adjusting docker-compose.yaml environment variables have you ensured those are mimicked in the Helm values.yaml file.

edknv and others added 3 commits February 3, 2026 22:03
- Add _compute_render_scale_to_fit helper for fit-to-box scaling
- Render at target resolution directly when scale_tuple specified
- Add edge case unit tests for degenerate inputs

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Signed-off-by: Jacob Ioffe <[email protected]>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 4, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants