Fixed summarization UDF to work with latest upstream changes#1213
Open
KyleZheng1284 wants to merge 1 commit intoNVIDIA:mainfrom
Open
Fixed summarization UDF to work with latest upstream changes#1213KyleZheng1284 wants to merge 1 commit intoNVIDIA:mainfrom
KyleZheng1284 wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
jperez999
reviewed
Dec 17, 2025
| max_tokens=400, | ||
| temperature=0.7, | ||
| ) | ||
| url = f"{base_url.rstrip('/')}/chat/completions" |
Collaborator
There was a problem hiding this comment.
Is this the only place this code will be used to call the summarizer? If not, should we consider making this into something that we can call in other places like a class or simply a function?
jioffe502
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed changes within summarization UDF
Pre Split (32 pages) was causing multiple summaries per file depending on the length. Example if total pages in PDF is 32-64 it will 2 summaries, if it has 64-96 pages it will have 3 summaries, ...
Fixed custom pipeline to use nemotron_parse* from depreciated nemoretriever-parse*
Minor upstream fixes
nvidia/nemotron-mini-4b-instructis 4096Checklist